Add OnConflict to InsertValues #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicate-ish tests is fine I think. Feel free to add other tests if you would like. Just give the descriptive names and descriptions |
|
The "reference" docs generated from the test suite are meant to be searched, so having a few extra cases probably isnt' a big deal |
|
@lihaoyi I found separate issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50
Fixed
Returning.InsertBase[V[Expr]]intoReturning.InsertBase[V[Column]], looks like an oversight,this basically enabled me to write an implicit in
OnConflictOpsthat made this fix possible@lihaoyi I'm not sure how to organize tests in this case, I hope you could have an idea, because current
OnConflictTestsare based on functionality and they don't distinguish between internal implementation of two different insert modes:InsertValuesandInsertColumns, I could have just duplicated the tests with.insert.values(???), but it doesn't seem right.Another question is that there are kinda missing tests for
InsertSelectand then conflicts, do you want me to add those or was it intentional to not have them?