Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Microsoft SQL server (1000USD Bounty) #17

Open
lihaoyi opened this issue Jul 22, 2024 · 5 comments · May be fixed by #29
Open

Add support for Microsoft SQL server (1000USD Bounty) #17

lihaoyi opened this issue Jul 22, 2024 · 5 comments · May be fixed by #29

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Jul 22, 2024 •
edited
Loading

From the maintainer Li Haoyi: I'm putting a 1000USD bounty on this issue, payable by bank transfer on a merged PR implementing this.

This should be relatively straightforward to add as a new dialect next to Postgres, MySQL, H2, and Sqlite. It should cover as much of the ScalaSQL API as possible, with exceptions or unsupported functionality marked with explanation comments in https://github.com/com-lihaoyi/scalasql/blob/main/scalasql/test/src/ConcreteTestSuites.scala. Tests should follow the existing pattern, and I believe TestContainers which we use for postgres and mysql should already have SQL server containers ready to go
@lihaoyi lihaoyi changed the title Add support for Microsoft SQL server Add support for Microsoft SQL server (500USD Bounty) Jul 22, 2024
@lihaoyi
Copy link
Member Author

lihaoyi commented Jul 22, 2024

Got for it

@valerii540
Copy link

@lihaoyi can I also try to implement this? Or is it considered as already "booked"?

@lihaoyi
Copy link
Member Author

lihaoyi commented Jul 29, 2024

@valerii540 go for it. There's no locking of bounties, they remain open until they are completed

@kiendang kiendang linked a pull request Sep 6, 2024 that will close this issue
Draft
@lihaoyi lihaoyi changed the title Add support for Microsoft SQL server (500USD Bounty) Add support for Microsoft SQL server (1000USD Bounty) Sep 15, 2024
@lihaoyi
Copy link
Member Author

lihaoyi commented Sep 15, 2024

Bumping the bounty from 500USD to 1000USD in view of the large amount of work apparently necessary to do this, as shown by the work that's gone into #29

@lihaoyi
Copy link
Member Author

lihaoyi commented Oct 28, 2024

For anyone reading, @kiendang has agreed to let anyone pick up his PR #29 as the basis for future work. The bounty is still open, so if anyone wants to pick up the torch and bring it across the finish line you're welcome to take a crack at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Microsoft SQL kiendang/scalasql
2 participants
@lihaoyi @valerii540