From 72711a1180238d849b320bf89dedfaea698a3b26 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:31:10 +0800 Subject: [PATCH 01/87] . From 628675abad5703569fcba2cbea8bb3e93415d240 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:32:02 +0800 Subject: [PATCH 02/87] . From 950d9e4cac097f5aed9d3b07def9fdf69e4c009e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:34:30 +0800 Subject: [PATCH 03/87] . --- .github/workflows/draft-status.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-status.yml index 9290dbb9a15..3ee8132f7f1 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-status.yml @@ -23,6 +23,6 @@ jobs: "state": "pending", "context": "Link to Fork Repo Actions", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use fork github actions until ready for review", + "description": "use fork github actions until ready for review" }' \ --fail-with-body From 590890663a45ffe84685ba0d39c82f60e6b2c9da Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:34:33 +0800 Subject: [PATCH 04/87] . From 81275e7f8890a07784c7407ea55f152276c34bd0 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 13:35:05 +0800 Subject: [PATCH 05/87] . From c5c7951268229acb71e37479d1e1fd75702d5a96 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:18:56 +0800 Subject: [PATCH 06/87] . --- .github/workflows/{draft-status.yml => draft-ci.yml} | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) rename .github/workflows/{draft-status.yml => draft-ci.yml} (81%) diff --git a/.github/workflows/draft-status.yml b/.github/workflows/draft-ci.yml similarity index 81% rename from .github/workflows/draft-status.yml rename to .github/workflows/draft-ci.yml index 3ee8132f7f1..b3dc3230c29 100644 --- a/.github/workflows/draft-status.yml +++ b/.github/workflows/draft-ci.yml @@ -1,11 +1,11 @@ -name: Draft Status +name: Draft CI permissions: write-all on: pull_request_target: jobs: - set_status: + run: if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all @@ -21,8 +21,8 @@ jobs: --header 'content-type: application/json' \ --data '{ "state": "pending", - "context": "Link to Fork Repo Actions", + "context": "Draft CI / run (pull_request_target)", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use fork github actions until ready for review" + "description": "use github actions on your repo fork until this PR is ready for review" }' \ --fail-with-body From d4d1d6d6c1b55032308812a74d8f3634ede6ca77 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:18:56 +0800 Subject: [PATCH 07/87] . From 747efc41997d619fa9702a72c5dd4f9bde8b77ac Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:19:42 +0800 Subject: [PATCH 08/87] . From a8d2b852ca7d2b544c515dd8ff128b19b2ccdc32 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:19:42 +0800 Subject: [PATCH 09/87] . From aa9a86bee543809f2d2b4ad5b59821b4cda89141 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:00 +0800 Subject: [PATCH 10/87] . From efd189fdace9f6705e5285d11dee5f2862550e96 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:00 +0800 Subject: [PATCH 11/87] . From 0fe03739ca4cf12f856f0f8e9d6e0831d8932fa9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:20:07 +0800 Subject: [PATCH 12/87] . From 25374c947eb91743b19dee4ae20a89154ce7935e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:27 +0800 Subject: [PATCH 13/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index b3dc3230c29..05c9170b5c8 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -21,7 +21,7 @@ jobs: --header 'content-type: application/json' \ --data '{ "state": "pending", - "context": "Draft CI / run (pull_request_target)", + "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use github actions on your repo fork until this PR is ready for review" }' \ From aaa10b812e0e2a449c4a205ad9f9bf7e96da2c35 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:27 +0800 Subject: [PATCH 14/87] . From fa41dc5376933cec87027ff9e7c5ead699673b16 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:24:34 +0800 Subject: [PATCH 15/87] . From aba7ec3ee04ada2d48cee8822dd7ed901f6e9558 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:18 +0800 Subject: [PATCH 16/87] . --- .github/ISSUE_TEMPLATE.md | 3 +++ .github/workflows/draft-ci.yml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index d75fe1f170a..a1562c19df5 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -2,3 +2,6 @@ Please don't open issues for questions, but ask in our Discussions forum at http Mill installations via `coursier` or `cs` are unsupported. +Please open all PRs as drafts to avoid being bottlenecked by Mill CI, and only +convert to ready for review once CI on your own fork is green. There will be a +PR status check linking your fork's commit/CI history for convenient viewing \ No newline at end of file diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 05c9170b5c8..c13ae7ca7e3 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -23,6 +23,6 @@ jobs: "state": "pending", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use github actions on your repo fork until this PR is ready for review" + "description": "use CI on your repo fork (link on right) until this PR is ready for review" }' \ --fail-with-body From c1a2081d19ef8296b197b66378b25a5336360222 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:18 +0800 Subject: [PATCH 17/87] . From 8fcdc1782cd523b146199b8e8ddd6dfbcd32ea65 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:27:25 +0800 Subject: [PATCH 18/87] . From d71d521726ff11833a0f49886fc122bb68eeb7d1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:36 +0800 Subject: [PATCH 19/87] . From d71c97e7507dcd596507fec1b5eaec3e898f91c7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:36 +0800 Subject: [PATCH 20/87] . From d41363267a7dd4866642f6bbc2254e7c19a05330 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:29:43 +0800 Subject: [PATCH 21/87] . From 4484ebfc01e45956d95b79b1dbf160ba47e1e1bc Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:50 +0800 Subject: [PATCH 22/87] . --- .github/workflows/draft-ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c13ae7ca7e3..97dd90b67f6 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -3,12 +3,16 @@ name: Draft CI permissions: write-all on: pull_request_target: + types: + - opened + - reopened + - synchronize jobs: run: if: github.event.pull_request.draft == true runs-on: ubuntu-latest - permissions: write-all + permissions: write-all steps: - name: Get PR source repository URL run: From 153f2730f80277982df25dcd4d51be58fb3bc159 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:50 +0800 Subject: [PATCH 23/87] . From a14817e66260f1b36398073e273bfb537f0feb9e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:32:57 +0800 Subject: [PATCH 24/87] . From ba3a4b64d79a81ae2c3215a2a7841b365b077d85 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:24 +0800 Subject: [PATCH 25/87] . From f1bf9fde0a0e4a2e36af58ed9b1d7ce0c44a2e11 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:24 +0800 Subject: [PATCH 26/87] . From d4dc387b1c6a8ca0ea1d24a856d43bcf41172ee4 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:33:31 +0800 Subject: [PATCH 27/87] . From 5bbc4932a9207544e7e0d54cffc63d7f9554231e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:21 +0800 Subject: [PATCH 28/87] . --- .github/workflows/draft-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 97dd90b67f6..68f0ac14569 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -7,10 +7,10 @@ on: - opened - reopened - synchronize + - ready_for_review jobs: run: - if: github.event.pull_request.draft == true runs-on: ubuntu-latest permissions: write-all steps: @@ -24,7 +24,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "pending", + "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == true) && 'pending' || 'success'}}", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use CI on your repo fork (link on right) until this PR is ready for review" From 389f55a3781d2b6bc599e1748aee2705e6d2bce9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:21 +0800 Subject: [PATCH 29/87] . From b0358f20b7e110a951d480af44f185fcb857a19e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:38:29 +0800 Subject: [PATCH 30/87] . From 95534517c273ddd32894c843244313579bf79964 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:28 +0800 Subject: [PATCH 31/87] . From 179f76363f63c22ac93d025287918ec3d02d7f84 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:28 +0800 Subject: [PATCH 32/87] . From b79cb95de8755c281e9ce8f5ff495aa58bdc2aeb Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:39:35 +0800 Subject: [PATCH 33/87] . From 9854ef7a48bd134ced808c9414d61e2606f8a8ec Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:06 +0800 Subject: [PATCH 34/87] . --- .github/workflows/draft-ci.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 68f0ac14569..571ddcb1c6e 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -15,7 +15,8 @@ jobs: permissions: write-all steps: - name: Get PR source repository URL - run: + run: | + echo ${{ github.event.action == 'ready_for_review' }} echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status run: | From 52b6b5b44b0e9d8d7b7b2244e86b6a56a1a4552e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:06 +0800 Subject: [PATCH 35/87] . From 8d6f8796de07e3e9c68352a7f6eb7d927e9f02d1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:13 +0800 Subject: [PATCH 36/87] . From fa68b7941a3211a299793966de71b03ef46ffc02 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:35 +0800 Subject: [PATCH 37/87] . --- .github/workflows/draft-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 571ddcb1c6e..f06756ae3cc 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -16,6 +16,7 @@ jobs: steps: - name: Get PR source repository URL run: | + echo ${{ github.event.action }} echo ${{ github.event.action == 'ready_for_review' }} echo "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}" - name: Create status From 35ab8e3503be0c8272fa7207fa45a8399a5cd408 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:35 +0800 Subject: [PATCH 38/87] . From a4de0ea21e94793e7bc227ecb5589d58f5838404 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:42:41 +0800 Subject: [PATCH 39/87] . From 3c9f8b56e6f3c05ba850cfcc9fc04449601caacb Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:52 +0800 Subject: [PATCH 40/87] . --- .github/workflows/draft-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index f06756ae3cc..b35bd38487f 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -14,7 +14,7 @@ jobs: runs-on: ubuntu-latest permissions: write-all steps: - - name: Get PR source repository URL + - name: Debug Echos run: | echo ${{ github.event.action }} echo ${{ github.event.action == 'ready_for_review' }} @@ -26,7 +26,7 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == true) && 'pending' || 'success'}}", + "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", "description": "use CI on your repo fork (link on right) until this PR is ready for review" From d2af03637f2812603cc579c104335dabe6df98de Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:52 +0800 Subject: [PATCH 41/87] . From fdf1f98096afd3b44927ee251a370c0f0ce1a694 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:44:58 +0800 Subject: [PATCH 42/87] . From 76c4d56fa5a93c5c2115aeb8efe9c819dae71917 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:49:53 +0800 Subject: [PATCH 43/87] . --- .github/workflows/draft-ci.yml | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index b35bd38487f..9682d2c74e1 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,9 +26,21 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", + "state": "${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && 'success' + || 'pending' + }}", "context": "Draft CI / link", - "target_url": "${{ github.event.pull_request.head.repo.html_url }}/commits/${{github.event.pull_request.head.ref}}", - "description": "use CI on your repo fork (link on right) until this PR is ready for review" + "target_url": '${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && null + github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref + }}', + "description": "${{ + (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) + && 'PR is ready for review, running CI in Mill repo' + || 'use CI on your repo fork (link on right) until this PR is ready for review' + }}" }' \ --fail-with-body From 1c36a22bdb656a3a6b3341b64223304eb8c5fd19 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:49:53 +0800 Subject: [PATCH 44/87] . From e1c8e8e5704365e4964fc00123ef07910e3b1012 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:00 +0800 Subject: [PATCH 45/87] . From 09ff98b06d43e9cf6f4e0784a6aa04af4912e405 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:57 +0800 Subject: [PATCH 46/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 9682d2c74e1..3666790e4eb 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -35,7 +35,7 @@ jobs: "target_url": '${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null - github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref + || github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref }}', "description": "${{ (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) From 36a67699c8f53ab996a904b15d7d6dc0b8963c7e Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:50:57 +0800 Subject: [PATCH 47/87] . From 7637df1b0e432dcf3c459d8963d46a1ff01a5496 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:51:03 +0800 Subject: [PATCH 48/87] . From d4aa9882063e870f7be54853c59af0ad93d452fa Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:05 +0800 Subject: [PATCH 49/87] . --- .github/workflows/draft-ci.yml | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 3666790e4eb..c5c3ec3de26 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,21 +26,9 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && 'success' - || 'pending' - }}", + "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && null - || github.event.pull_request.head.repo.html_url + '/commits/' + github.event.pull_request.head.ref - }}', - "description": "${{ - (github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) - && 'PR is ready for review, running CI in Mill repo' - || 'use CI on your repo fork (link on right) until this PR is ready for review' - }}" + "target_url": '${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null || join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From a2eec7957a440d2cc05a44437af56fff226f05a6 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:05 +0800 Subject: [PATCH 50/87] . From 7a535cec8dbab47cd120f48ffc17376c25ddd5e9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:53:12 +0800 Subject: [PATCH 51/87] . From dce0438eb8240f11b317cca77c20dd3e28a6de37 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:02 +0800 Subject: [PATCH 52/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c5c3ec3de26..38fc571016a 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && null || join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "target_url": '${{ github.event.pull_request.head.repo.html_url }}/commits/ ${{github.event.pull_request.head.ref}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 84507a5f18ca37efea0e6b55bc6ab0c0773e587f Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:02 +0800 Subject: [PATCH 53/87] . From c88ca3747b1bf6c6df5c42b0dc463afd79326ae8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:09 +0800 Subject: [PATCH 54/87] . From a21d0ab6d4d2be1033a382039584f6f5e89a4f38 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:58 +0800 Subject: [PATCH 55/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 38fc571016a..98a3cc8dc3d 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{ github.event.pull_request.head.repo.html_url }}/commits/ ${{github.event.pull_request.head.ref}}', + "target_url": '${{join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 575b43fb9673435f00e73d4537f05974224d91ef Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:54:58 +0800 Subject: [PATCH 56/87] . From 2ff27cdbd28db4a3ce3e5a949b704bb263087f92 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:55:06 +0800 Subject: [PATCH 57/87] . From 97204778ec11062fadff5c8784f5444e612a34cf Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:22 +0800 Subject: [PATCH 58/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index 98a3cc8dc3d..c82c6486901 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", "context": "Draft CI / link", - "target_url": '${{join([github.event.pull_request.head.repo.html_url, '/commits/', github.event.pull_request.head.ref])}}', + "target_url": '${{format('{0}/commits/{1}', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref)}}', "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" }' \ --fail-with-body From 12e835c140eb5d635eea0059f02402cbee056c64 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:22 +0800 Subject: [PATCH 59/87] . From a84d590b897ba2df54cd28bc3968e7d879806af4 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:56:28 +0800 Subject: [PATCH 60/87] . From 9866a44e3f60be19bcd328bb41e80fe6680d92d9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:40 +0800 Subject: [PATCH 61/87] . --- .github/workflows/draft-ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index c82c6486901..f106a42ec97 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -26,9 +26,9 @@ jobs: --header 'authorization: Bearer ${{ secrets.GITHUB_TOKEN }}' \ --header 'content-type: application/json' \ --data '{ - "state": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'success' || 'pending'}}", + "state": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'pending' || 'success'}}", "context": "Draft CI / link", - "target_url": '${{format('{0}/commits/{1}', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref)}}', - "description": "${{(github.event.action == 'ready_for_review' || github.event.pull_request.draft == false) && 'PR is ready for review, running CI in Mill repo' || 'use CI on your repo fork (link on right) until this PR is ready for review'}}" + "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || null}}, + "description": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'use CI on your repo fork (link on right) until this PR is ready for review' || 'PR is ready for review, running CI in Mill repo'}}" }' \ --fail-with-body From 1c461209469058ca490f568ebb66d7a14e3d7cf7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:40 +0800 Subject: [PATCH 62/87] . From 408e3125ed845b206960f4712ad88c2a0763aeac Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:57:47 +0800 Subject: [PATCH 63/87] . From bf94983fb95017ad512f53679ee99294b6134026 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:43 +0800 Subject: [PATCH 64/87] . --- .github/workflows/draft-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/draft-ci.yml b/.github/workflows/draft-ci.yml index f106a42ec97..a9b9fcee385 100644 --- a/.github/workflows/draft-ci.yml +++ b/.github/workflows/draft-ci.yml @@ -28,7 +28,7 @@ jobs: --data '{ "state": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'pending' || 'success'}}", "context": "Draft CI / link", - "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || null}}, + "target_url": ${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && format('"{0}/commits/{1}"', github.event.pull_request.head.repo.html_url, github.event.pull_request.head.ref) || 'null'}}, "description": "${{(github.event.action != 'ready_for_review' && github.event.pull_request.draft) && 'use CI on your repo fork (link on right) until this PR is ready for review' || 'PR is ready for review, running CI in Mill repo'}}" }' \ --fail-with-body From 6ecef188dcff5d88d92d74281e93ceecdcdc14e9 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:43 +0800 Subject: [PATCH 65/87] . From b1b978a28c9cdff7750599d4ee2943e40a991e25 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 15:59:50 +0800 Subject: [PATCH 66/87] . From 49306e1eb66f5aab2ef061ac15cb37de462d5e46 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:30 +0800 Subject: [PATCH 67/87] . From 7bd2504131393ba76d474a3a8b20a19890c6d98c Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:30 +0800 Subject: [PATCH 68/87] . From c94eb480fa9cd5e92d74a77a2bddf0e5219f98c8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:01:37 +0800 Subject: [PATCH 69/87] . From da719543c10027e6ce0ecca5cb760b18f73896f0 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:19 +0800 Subject: [PATCH 70/87] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 1165cfa3093..56446dfa660 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.pull_request.draft == false + if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From eab25d00a693954ae9c17d01fa2613dbcd8fded7 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:19 +0800 Subject: [PATCH 71/87] . From a676bc2c82805d21d28aa54dd14cabe912ac2621 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:25 +0800 Subject: [PATCH 72/87] . From 46f0fdb49d361b53a59452fcfba5a46a19381dc2 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:50 +0800 Subject: [PATCH 73/87] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 56446dfa660..72637819453 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' && github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From bcd3655474a971ca6fbcd8daee6b7a06560c1967 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:50 +0800 Subject: [PATCH 74/87] . From 3c8efa6124b14de6bed4512129879d0a4d5f29af Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:02:57 +0800 Subject: [PATCH 75/87] . From e2891af010d330f5c1c650cc4216945c1693f875 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:46 +0800 Subject: [PATCH 76/87] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 72637819453..6135529fd7c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft != false + if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From bd801e3a07db09c00978be2ee950ff4f7b3a00d5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:46 +0800 Subject: [PATCH 77/87] . From 9cb9e7ffee8708444ab1aeefcf3c59abf5b184e8 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:03:54 +0800 Subject: [PATCH 78/87] . From aa2f4a1e48f2cd4acf0954573d02bf599e693cee Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:28 +0800 Subject: [PATCH 79/87] . --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 6135529fd7c..e56b61aa070 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,7 +29,7 @@ jobs: # Jobs are listed in rough order of priority: if multiple jobs fail, the first job # in the list should be the one that's most worth looking into build-linux: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) uses: ./.github/workflows/run-mill-action.yml with: java-version: '11' @@ -37,7 +37,7 @@ jobs: populate_cache: true build-windows: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) uses: ./.github/workflows/run-mill-action.yml with: os: windows-latest @@ -46,7 +46,7 @@ jobs: populate_cache: true test-docs: - if: github.event.action == 'ready_for_review' || github.event.pull_request.draft == false + if: (github.event.action == 'ready_for_review') || (github.event.pull_request.draft == false) runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From eea45e65ef2723cd20319a2e795123857027a8e2 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:28 +0800 Subject: [PATCH 80/87] . From ed1dba927edb76191bcf8e25ffe3da5f42426660 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:05:35 +0800 Subject: [PATCH 81/87] . From fbba493a15217216037052df85d4a4ac41486ce5 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:46 +0800 Subject: [PATCH 82/87] . From 50fb8e4c4f0daf7910875511241e0a8d8c83e0b1 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:46 +0800 Subject: [PATCH 83/87] . From d820fe4c717119cbfcf19c310ca55ab59709a16a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:27:54 +0800 Subject: [PATCH 84/87] . From 8910d3ef035c05f0515ca340d92f39313dfb237a Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:29 +0800 Subject: [PATCH 85/87] . From 2bdbf248fecfb030169300d0266f84f3a5201e93 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:29 +0800 Subject: [PATCH 86/87] . From 230e40ad0c33f8f8cee0ed03d37060e988a68724 Mon Sep 17 00:00:00 2001 From: Li Haoyi Date: Fri, 13 Sep 2024 16:55:36 +0800 Subject: [PATCH 87/87] .