-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strange overlap report after adding another route #96
Comments
This appears to be a limitation in the Mill routing logic; it doesn't realize the |
The framework looks very nice to me as an idea (typical Li Haoyi Easy, Boring and Fast), but my first experience is there are some rough egdes which make work unpleasant up to the level of nearly impossible. I hope you will not be annoyed by me raising issues I may have - I will try to stay factual and brief. |
Please do continue to report issues. We need these reports in order to improve the framework, so they are very much appreciated |
This one is currently a blocker for me. I am unable to implement OAuth for my app, as I am unable to handle Btw, routing directly is Scala based on request.remainingPathSegments match {
case Seq("auth") =>
authRoute(request)
case Seq("favicon.ico") =>
resourceRoute("html/favicon.ico").withContentType("image/x-icon")
case "classes" +: prefix +: path if whiteListClasses.contains(prefix) =>
resourceRoute((prefix +: path).mkString("/")).withAutoContentType(path.last)
case Seq(path) if path.endsWith(".js") =>
jsRoute(path).withContentType("text/javascript")
} |
No longer a blocker, this is my "catch them all" endpoint at the moment: @get("/", subpath = true)
def root(code: Option[String] = None, state: Option[String] = None, request: Request): Response[Response.Data] It is kind of strange to declare all possible query parameters this way, as I am using them directly from the request eventually, but it works and allows me to proceed. |
#134 might have also fixed this. Is this still an issue? |
My app uses a single "catch them all" wildcard at the moment and I am working on different things now. The intensions seems reasonable and well thought and it should fix this. |
Following code prints error when run:
The error is:
When I replace the "/root/x" route with "/", the error disappears (this is how default
MinimalApplication
looks like).The text was updated successfully, but these errors were encountered: