Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silverstripe 4 upgrade #15

Open
jelicanin opened this issue Sep 25, 2018 · 3 comments
Open

Silverstripe 4 upgrade #15

jelicanin opened this issue Sep 25, 2018 · 3 comments

Comments

@jelicanin
Copy link

Hi @colymba
I'm working on Silverstripe 4 upgrade of your module.
Please check progress @ https://github.com/fractaslabs/silverstripe-colorfield
@colymba
Copy link
Owner

colymba commented Sep 29, 2018

cool thanks! Do you think we could manage the jquery-minicolors dependency via composer, so we don't have to have our own vendor plugin. Would make dependency management much easier.

@jelicanin
Copy link
Author

Yeah, why not

jelicanin added a commit to fractaslabs/silverstripe-colorfield that referenced this issue Dec 21, 2018
@jelicanin
Fix colymba#15
237d860 
Add abeautifulsite/jquery-minicolors package as composer requirement
Expose lib front-end resources with Silverstripe vendor-expose
@jelicanin
Copy link
Author

Hi @colymba
after some testing and research this idea about jquery-minicolors dependency via composer I founded it is a tricky job to do.

So, for now we can use third party lib embedded in module until silverstripe/vendor-plugin allows us to expose another vendor module's resources from your own module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jelicanin @colymba