Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing TRC Files with Extended Frames Reads as Standard Frame #771

Open
nlopified opened this issue Apr 23, 2024 · 0 comments
Open

Importing TRC Files with Extended Frames Reads as Standard Frame #771

nlopified opened this issue Apr 23, 2024 · 0 comments

Comments

@nlopified
Copy link

Given this test file here, we would expect these frames (5, 6, 7, 13, 14, and 15) to show as Standard Frames and all others in the test log to show as Extended Frames (given that their IDs are greater than 0x7FF).

In the framefileio.cpp file, under bool FrameFileIO::loadPCANFile( we see that an extended frame is only set when the 29th bit of the ID is equal to 1.

if (thisFrame.frameId() > 0x10000000)
{
    thisFrame.setExtendedFrameFormat(true);
}
else
{
    thisFrame.setExtendedFrameFormat(false);
}

Instead the first line of the detection should be:
if (thisFrame.frameId() > 0x7FF)

This issue is seen on lines 1443, 1495, 1537, and 1589 on Release V213.

SavvyCAN_TestLog.trc.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant