search_builder still showing in menu find for some occurrences when using ca_occurrences_breakout_find_by_type_in_submenu

[thCAgh]

Whats the issue: Even disabling search builder for occurrences in app.conf, the search builder option is showing and when clicking on it, uncaught fatal error occurs. Is particularly showing the search builder option for occurrence_types without third "generation" in hierarchy (aka those occurrence_types without childs).

Version: Providence dev/php8

How to reproduce:

• Set all the ca_*_disable_search_builder=1, ca_occurrences_breakout_find_by_type_in_submenu = 0 and ca_occurrences_breakout_find_by_type_in_menu = 1.
• Set occurrence_types hierarchy like this

parent	1st hierarchy	2nd hierarchy
occurrence_types	exhibitions
occurrence_types	procedures	Proc 1
occurrence_types	procedures	Proc 2
occurrence_types	procedures	Proc 3
occurrence_types	procedures	Proc 4
occurrence_types	publications

Whats showing in the menu:

menu	submenu	sub-submenu
Find	exhibitions	Basic search
Find	exhibitions	advanced search
Find	exhibitions	search builder
Find	exhibitions	explore
Find	procedures	Proc 1
Find	procedures	Proc 2
Find	procedures	Proc 3
Find	procedures	Proc 4
Find	publications	Basic search
Find	publications	advanced search
Find	publications	search builder
Find	publications	explore

Feedback in glitter
I spoke with Monica and she suggested to fill an issue since it looks in her workds:

it's something to do with the dynamic menu creation for find when ca_*breakout_by_type_in*menu is set to true. So most likely an bug in /app/lib/BaseSearchController.php which generates this.

[collectiveaccess]

Should be fixed with fa4c02a