Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of Credis_Cluster is not in line with documentation #151

Open
talo11 opened this issue Aug 17, 2021 · 1 comment
Open

Deprecation of Credis_Cluster is not in line with documentation #151

talo11 opened this issue Aug 17, 2021 · 1 comment

Comments

@talo11
Copy link

talo11 commented Aug 17, 2021

The class Credis_Cluster is marked as deprecated, and so are methods in Credis_Sentinel that are referencing Credis_Cluster, such as createCluster() and getCluster().

However, the documentation in README.markdown suggests using these methods for automatic failover with Sentinel, like this:

$sentinel = new Credis_Sentinel(new Credis_Client('127.0.0.1',26379));
$masterAddress = $sentinel->getMasterAddressByName('mymaster');
$cluster = $sentinel->getCluster('mymaster');

Is the documentation outdated? If so, how should automatic failover with Sentinel be set up using Credis to be compatible with future versions?

@colinmollenhour
Copy link
Owner

It was just never used or tested heavily to my knowledge and it predates and is made obsolete by the official Redis Cluster so I wouldn't recommend using it and would instead advise to consider using Redis Cluster if it meets your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants