How to close a Snapshot after using it to read a file from disk cache ?

[LeMimit]

Hello !

First, thanks for this amazing library.

I was trying to use the new DiskCache from the version 2.0.0-alpha05.

I saw in the documentation that calling Snapshot.close or Snapshot.closeAndEdit is really important.

    /**
     * Get the entry associated with [key].
     *
     * IMPORTANT: **You must** call either [Snapshot.close] or [Snapshot.closeAndEdit] when finished
     * reading the snapshot. An open snapshot prevents editing the entry or deleting it on disk.
     */
    operator fun get(key: String): Snapshot?

After, I was looking around and I saw that in the code of HttpUriFetcher which access to the DiskCache in some case neither Snapshot.close or Snapshot.closeAndEdit are called.

For example here

                // Always return cached images with empty metadata as they were likely added manually.
                if (snapshot.metadata.length() == 0L) {
                    return SourceResult(
                        source = snapshot.toImageSource(),
                        mimeType = getMimeType(url, null),
                        dataSource = DataSource.DISK
                    )
                }

Is it a bug or did I not understand somethink ? Can you help me ?

Thanks !

[colinrtwhite]

Thanks! And yep, this is intentional as we need to keep the disk snapshot open until it's finished being read by a Decoder. Otherwise, the file in the disk cache could be deleted while it's being decoded. It's always eventually closed here even if there's an uncaught exception.

[LeMimit]

Thanks for the answer. Ok I understand now !