Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace set-port with set-address for simplification #26

Open
cayasso opened this issue Jul 20, 2016 · 3 comments
Open

Replace set-port with set-address for simplification #26

cayasso opened this issue Jul 20, 2016 · 3 comments

Comments

@cayasso
Copy link
Collaborator

cayasso commented Jul 20, 2016

It would be great to have one single command address or set-address that can set http, https and bolt (-a, -s, -b)

For example

$ ineo set-address -a 0.0.0.0:3434 -s localhost:3435 -b 0.0.0.0:3436
$ ineo set-address -a 0.0.0.0:3434 -s 3435 -b 0.0.0.0:3436
$ ineo set-address -a 3434 -s 3435 -b 3436

This would remove the need of having two commands one for address (set-address) and one for port (set-port) for each address type.

@carlosforero carlosforero added this to the Version 1.2.0 milestone Jul 21, 2016
@carlosforero
Copy link
Member

@barttv and @tlauwyck are working in a feature (#24) that already includes setting http/https/bolt ports. So is better to wait their PR before to start working on this issue.

@cayasso
Copy link
Collaborator Author

cayasso commented Jul 21, 2016

@carlosforero I already got set-address working last night ;-) I can create a gist with the code so you can take a look at the approach, and yes I was planing to wait for v.1.1 and then add my changes on top.

What do you think?

@carlosforero
Copy link
Member

carlosforero commented Jul 21, 2016

@cayasso I think is a perfect plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants