Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FinishReason enum on server side #914

Open
danylo-boiko opened this issue Jan 20, 2025 · 0 comments
Open

Add FinishReason enum on server side #914

danylo-boiko opened this issue Jan 20, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@danylo-boiko
Copy link
Contributor

What improvement(s) are you suggesting?

In the current implementation, we do not have type generation for the FinishReason enum. Move this enum to the server side, replace all instances of string constants (search for "finish_reason"), and use the type generated by make generate-client-web on the client side.

Additional information

No response
@tianjing-li tianjing-li added the good first issue Good for newcomers label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tianjing-li @danylo-boiko