Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return token_strings in Client.tokenize() when offline=True #494

Closed
wants to merge 1 commit into from
Closed

Return token_strings in Client.tokenize() when offline=True #494

wants to merge 1 commit into from

Conversation

yifanmai
Copy link

@yifanmai yifanmai commented May 7, 2024

Fixes #493

@CLAassistant
Copy link

CLAassistant commented May 7, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abdullahkady
Copy link
Contributor

Thanks @yifanmai for the contribution!

We intentionally skipped this when we introduced offline local tokenization; since we were optimizing for time. However, let me check how much overhead this adds (for bigger inputs) and if it's negligible we can add it.

@yifanmai
Copy link
Author

yifanmai commented Jan 7, 2025

Noted, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abdullahkady abdullahkady Awaiting requested review from abdullahkady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offline tokenization produces empty token_strings
4 participants
@yifanmai @CLAassistant @abdullahkady @billytrend-cohere