Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Response #12

Open
vlopes11 opened this issue Sep 30, 2022 · 0 comments
Open

Simplify Response #12

vlopes11 opened this issue Sep 30, 2022 · 0 comments

Comments

@vlopes11
Copy link
Member

vlopes11 commented Sep 30, 2022

Is your feature request related to a problem? Please describe.
The BreakpointLocationsResponse containts a body that points to Vec<BreakpointLocation>. This is redundant and extends the encoding/decoding pattern, that shouldn't necessarily reflect the Rust API

Describe the solution you'd like
Transitively, it should just be a Vec<BreakpointLocation>. This is an example and is also applicable to the other responses that are enforcing an additional level via body when this, for the library level, is just redundant and doesn't improve the API

Describe alternatives you've considered
Using a literal representation of the specifications will not benefit from the features of Rust and might even be too confusing/verbose.

Additional context
N/A

@vlopes11 vlopes11 changed the title Simplify BreakpointLocationsResponse Simplify Response Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant