Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle properly situations when the image displaying is not supported. #39

Open
rexim opened this issue Sep 6, 2015 · 6 comments
Open
Assignees
Labels

Comments

@rexim
Copy link
Member

rexim commented Sep 6, 2015

http://www.gnu.org/software/emacs/manual/html_node/elisp/Display-Feature-Testing.html

@rexim rexim self-assigned this Sep 6, 2015
@rexim
Copy link
Member Author

rexim commented Sep 6, 2015

I didn't decide yet what we should do in case of unsupported image displaying. We can close the game with the corresponding message or we can fallback to ascii graphics. Using the fallback to ascii graphics may help to fix #38

@Minoru
Copy link
Member

Minoru commented Sep 6, 2015

On Sun, Sep 06, 2015 at 12:49:14PM -0700, Alexey Kutepov wrote:

We can fail

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

If you will insist on supporting ASCII, I will insist on supporting
Braille as well :P

Seriously, though, I think you shouldn't stretch yourself too thin.
Failing is fine. You can deal with ASCII later, if you're so inclined.

Regards,
Alexander Batischev

@rexim
Copy link
Member Author

rexim commented Sep 6, 2015

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

It's not about the hardware. Many people use Emacs in a bare console. Also I hoped that ASCII would help us to fix #38 but I already closed that issues because I thought that it's too much responsibility for the unit tests.

You can deal with ASCII later, if you're so inclined.

Of course I will do this later! That's why I've put the backlog label on it. :)

Also, since #38 is closed I think we'll stick with the "failing" scenario. But I don't wanna plan this issue on the 5th Tsoding because I want to have something playable as soon as possible. So I plan only tasks that are essential for getting us there. :)

@rexim rexim added the quick label Sep 7, 2015
@Minoru
Copy link
Member

Minoru commented Sep 7, 2015

On Sun, Sep 06, 2015 at 01:40:06PM -0700, Alexey Kutepov wrote:

"Here's a nickel, kid; go buy yourself a graphics-capable computer."

It's not about the hardware. Many people use Emacs in a bare console.

I was only kidding ;)

Regards,
Alexander Batischev

@rexim
Copy link
Member Author

rexim commented Sep 7, 2015

I was only kidding ;)

ok :)

@rexim rexim removed backlog labels Oct 4, 2015
@rexim
Copy link
Member Author

rexim commented Oct 12, 2015

By the way, the ASCII fallback could be useful for Integration Testing on Travis #77

@rexim rexim added the boring label Oct 24, 2015
@rexim rexim removed the boring label Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants