New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review DiscoveryConfig defaults and values #58

Open

cskiraly opened this issue Jun 2, 2023 · 1 comment

Collaborator

cskiraly commented Jun 2, 2023

In test DiscoveryConfig is set to DiscoveryConfig.init(1000, 24, 5)
https://github.com/codex-storage/nim-libp2p-dht/blob/4375b9229815c332a3b1a9d0091d5cf5a74adb2e/tests/dht/test_helper.nim#L34

This calls
https://github.com/codex-storage/nim-libp2p-dht/blob/4375b9229815c332a3b1a9d0091d5cf5a74adb2e/libp2pdht/private/eth/p2p/discoveryv5/protocol.nim#L1013-L1017

Which sets tableIpLimit, bucketIpLimit, bitsPerHop. Default values should be reviewed for tests and for deployment.

The text was updated successfully, but these errors were encountered:

Collaborator Author

cskiraly commented Jun 2, 2023

@benbierens, bucketIpLimit might be influencing your tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment