Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum Request's duration #101

Open
Tracked by #46
AuHau opened this issue May 7, 2024 · 2 comments · May be fixed by #206
Open
Tracked by #46

Maximum Request's duration #101

AuHau opened this issue May 7, 2024 · 2 comments · May be fixed by #206
Assignees
Labels
blocked This issue is blocked by some other work Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details

Comments

@AuHau
Copy link
Member

AuHau commented May 7, 2024

When we want to migrate our smart contracts, we need the ability to deprecate the old contract but it needs to be alive until the last Request finishes/fails/cancelles. We should hence prevent somebody from creating very long contracts which would hinder this process and hence have an upper limit for the Request's duration.

What would be a reasonable limit? 6 months? 3 months?

@AuHau AuHau added the Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details label May 7, 2024
@AuHau
Copy link
Member Author

AuHau commented May 16, 2024

I would like to figure out two limits - soft and hard.

Hard-limit would be the limit that would make sense from system and economic side and structure around it the internal types of the smart contract (for example scaling of proof probabilities and related counters).

Soft-limit would be "artificial" limit imposed by us in order to guarantee the upgradability aspect of the contract. We could even have the possibility of updating this limit "on the fly", but not sure if it is desirable...

@AuHau
Copy link
Member Author

AuHau commented May 16, 2024

We have figured out these limits:

  • hard limit will be based on uint32 which should gives us 138 years
  • soft limit will be for start a month

@AuHau AuHau linked a pull request Dec 30, 2024 that will close this issue
@AuHau AuHau self-assigned this Jan 23, 2025
@AuHau AuHau added the blocked This issue is blocked by some other work label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by some other work Marketplace See https://miro.com/app/board/uXjVNZ03E-c=/ for details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant