Merge pull request #2087 from tf/user-attribute-table

Make user admin attributes table extensible

admins/pageflow/user.rb

@@ -38,21 +38,7 @@ module Pageflow
 
     show do |user|
       div do
-        attributes_table_for user do
-          row :last_name, class: 'last_name'
-          row :first_name, class: 'first_name'
-          row :email, class: 'email'
-
-          row :created_at
-          row :last_sign_in_at
-          boolean_status_tag_row :suspended?
-          row :locale do
-            I18n.t('language', locale: user.locale)
-          end
-          if authorized?(:see_admin_status, user)
-            boolean_status_tag_row(:admin?, 'admin warning')
-          end
-        end
+        render('attributes_table', user:)
 
         para do
           link_to I18n.t('pageflow.admin.users.resend_invitation'),

app/views/admin/users/_attributes_table.html.arb

@@ -0,0 +1,13 @@
+extensible_attributes_table_for(user, Pageflow.config.admin_attributes_table_rows.for(:user)) do
+  row :last_name, class: 'last_name'
+  row :first_name, class: 'first_name'
+  row :email, class: 'email'
+
+  row :created_at
+  row :last_sign_in_at
+  boolean_status_tag_row :suspended?
+  row :locale do
+    I18n.t('language', locale: user.locale)
+  end
+  boolean_status_tag_row(:admin?, 'admin warning') if authorized?(:see_admin_status, user)
+end

spec/controllers/admin/users_controller_spec.rb

@@ -128,6 +128,22 @@ def self.name
           end
         end
       end
+
+      describe 'additional attributes table rows' do
+        it 'renders additional rows registered for user' do
+          user = create(:user)
+          create(:account, with_manager: user)
+
+          pageflow_configure do |config|
+            config.admin_attributes_table_rows.register(:user, :custom) { 'custom attribute' }
+          end
+
+          sign_in(user, scope: :user)
+          get(:show, params: {id: user.id})
+
+          expect(response.body).to have_text('custom attribute')
+        end
+      end
     end
 
     describe 'get #quota_state' do