Skip to content

Commit 26870f7

Browse files
authored
feat: adds dataAttributes to linkPressTargetToOnDOMLinkPressArgs in plugins-core (native-html#45)
formidable-webview/webshell has added dataAttributes to LinkPressTarget in September 2021. [1] This commit adds it to linkPressTargetToOnDOMLinkPressArgs so that data attributes on achor tags are available in onPress-handlers. [1] formidable-webview/webshell@0a2c3e0
1 parent bbbb9b6 commit 26870f7

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/plugins-core/src/__tests__/linkPressTargetToOnDOMLinkPressArgs.test.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@ describe('linkPressTargetToOnDOMLinkPressArgs', () => {
1212
href: 'https://google.com/',
1313
hreflang: 'en',
1414
id: 'anchor03',
15-
target: '_blank'
15+
target: '_blank',
16+
data: { custom: 'data' }
1617
},
1718
'_blank'
1819
];
@@ -31,7 +32,8 @@ describe('linkPressTargetToOnDOMLinkPressArgs', () => {
3132
relAttribute: null,
3233
targetAttribute: '_blank',
3334
typeAttribute: null,
34-
uri: 'https://google.com/'
35+
uri: 'https://google.com/',
36+
dataAttributes: { custom: 'data' }
3537
})
3638
).toEqual(expectedOutput);
3739
});

packages/plugins-core/src/linkPressTargetToOnDOMLinkPressArgs.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@ export default function linkPressTargetToOnDOMLinkPressArgs({
1919
nameAttribute,
2020
referrerpolicyAttribute,
2121
relAttribute,
22-
typeAttribute
22+
typeAttribute,
23+
dataAttributes
2324
}: LinkPressTarget): Parameters<Required<RenderersProps['a']>['onPress']> {
2425
const attributes = {
2526
class: classAttribute,
@@ -31,7 +32,8 @@ export default function linkPressTargetToOnDOMLinkPressArgs({
3132
referrerpolicy: referrerpolicyAttribute,
3233
rel: relAttribute,
3334
type: typeAttribute,
34-
target: targetAttribute
35+
target: targetAttribute,
36+
data: dataAttributes
3537
};
3638
for (const name in attributes) {
3739
if (attributes[name] == null) {

0 commit comments

Comments
 (0)