Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent_farm] fix scroll in chat #1287

Open
1 task
theskcd opened this issue Feb 13, 2025 · 2 comments · May be fixed by #1288
Open
1 task

[agent_farm] fix scroll in chat #1287

theskcd opened this issue Feb 13, 2025 · 2 comments · May be fixed by #1288
Labels
bug Something isn't working

Comments

@theskcd
Copy link
Contributor

theskcd commented Feb 13, 2025

Before submitting your bug report

  • I'm not able to find an open issue that reports the same bug

Environment

- OS:
- Sidecar commit:
- IDE commit:

Description

Right now in the AideAgent panel, we already have autoscroll set up. But sometimes when there is a diff element that comes in, the diff element actually grows in both directions - it grows larger and it grows smaller. When it grows smaller, the scrolling autoscroll logic that we have doesn't automatically scroll to the bottom and it actually gets stuck to the last scroll position. Ideally, regardless of whether it is increasing or decreasing in size, the autoscroll should work.

Reproduction

No response

Log output

@theskcd theskcd added the bug Something isn't working label Feb 13, 2025
@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

ACK, on it!

@theskcd
Copy link
Contributor Author

theskcd commented Feb 13, 2025

🔄 Bug Fix: Resolved scroll issue in AideAgent chat panel when diff elements change size

  • Fixed: Improved onDidChangeTreeContentHeight method in ChatWidget class to maintain scroll position at the bottom during both growth and shrinkage of diff elements
  • Changed: Implemented more reliable "near bottom" detection and consistent auto-scrolling behavior with clearer variable names and comments

This fix ensures the chat view remains properly positioned during dynamic content changes, especially when diff elements collapse. Please review the changes and confirm the scrolling behavior works as expected in all scenarios.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant