Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lien to the code dictionary #3631

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikolaik
Copy link

@nikolaik nikolaik commented Feb 3, 2025

Since lien is a word frequently used when working with the Google
Terraform Provider, it feels wrong to treat it as a typo.

Humbly suggesting to revert that change

This reverts commit 536ccb5.

Fixes #3630

@nikolaik nikolaik requested a review from peternewman as a code owner February 3, 2025 09:31
@DimitriPapadopoulos DimitriPapadopoulos added the dictionary Changes to the dictionary label Feb 3, 2025
@DimitriPapadopoulos
Copy link
Collaborator

Note that this typo is in the rare dictionary. Perhaps the rare dictionary should not be selected by default.

Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these to the code dictionary please, which seems like the right place to me given they upset programming related text, but are still potentially valid/useful outside of that domain.

@nikolaik nikolaik force-pushed the nikolaik/revert-lien branch from 107c1a1 to e41cf86 Compare February 5, 2025 15:41
@nikolaik nikolaik requested a review from peternewman February 5, 2025 15:41
@nikolaik nikolaik force-pushed the nikolaik/revert-lien branch from e41cf86 to 300afdc Compare February 5, 2025 15:43
@nikolaik nikolaik changed the title Revert "Add rare typo lien->line" Move lien to the code dictionary Feb 5, 2025
@nikolaik
Copy link
Author

nikolaik commented Feb 5, 2025

Can you move these to the code dictionary please, which seems like the right place to me given they upset programming related text, but are still potentially valid/useful outside of that domain.

Moved now

@DimitriPapadopoulos
Copy link
Collaborator

DimitriPapadopoulos commented Feb 5, 2025

@peternewman @nikolaik It seems to me that lien is not related to programming, but to a specific domain.

@nikolaik
Copy link
Author

nikolaik commented Feb 5, 2025

@peternewman @nikolaik It seems to me that lien is not related to programming, but to a specific domain.

I agree with you @DimitriPapadopoulos but no strong opinion, so open to go either way

@peternewman
Copy link
Collaborator

@peternewman @nikolaik It seems to me that lien is not related to programming, but to a specific domain.

When you say specific domain do you mean Google Terraform? Isn't that the same as say:

Which is only relevant to Assembler (AFAIK), to pick probably one of the more obscure ones?

@rjmoseley
Copy link

From my perspective it's not particularly related to programming, it's a legal term that just so happens to be used by Google Cloud Platform. Whilst it's that usage that has resulted in this debate, fundamentally it's just a word, and one I (native British English speaker) was familiar with long before I came across it's usage in GCP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dictionary Changes to the dictionary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider reverting lien->line
4 participants