-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move lien
to the code dictionary
#3631
base: main
Are you sure you want to change the base?
Conversation
Note that this typo is in the rare dictionary. Perhaps the rare dictionary should not be selected by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move these to the code dictionary please, which seems like the right place to me given they upset programming related text, but are still potentially valid/useful outside of that domain.
107c1a1
to
e41cf86
Compare
e41cf86
to
300afdc
Compare
lien->line
"lien
to the code dictionary
Moved now |
@peternewman @nikolaik It seems to me that |
I agree with you @DimitriPapadopoulos but no strong opinion, so open to go either way |
When you say specific domain do you mean Google Terraform? Isn't that the same as say:
Which is only relevant to Assembler (AFAIK), to pick probably one of the more obscure ones? |
From my perspective it's not particularly related to programming, it's a legal term that just so happens to be used by Google Cloud Platform. Whilst it's that usage that has resulted in this debate, fundamentally it's just a word, and one I (native British English speaker) was familiar with long before I came across it's usage in GCP. |
Since
lien
is a word frequently used when working with the GoogleTerraform Provider, it feels wrong to treat it as a typo.
Humbly suggesting to revert that change
This reverts commit 536ccb5.
Fixes #3630