fix : element click intercepted

Have tested and it seems good, You only get the ElementClickInterceptedException when for example there's a div covering the input and it thinks it'll click the wrong thing- I did hpwver add a wait which should wait until it's there. General robustness.. Seems OK.

Author: jackbayliss

missionchief_bot.py

@@ -1,5 +1,9 @@
 from selenium import webdriver
 from selenium.common.exceptions import NoSuchElementException,ElementClickInterceptedException
+from selenium.webdriver.common.by import By
+from selenium.webdriver.support.ui import WebDriverWait
+from selenium.webdriver.support import expected_conditions as EC
+
 import time
 import platform
 import os
@@ -271,16 +275,31 @@ def despatchVehicles(self,mission):
                     logger.debug("Mission still needs vehicles, despatching.")
                     print("Despatching " + ownedVehicle.getName() + " to " + mission.getName())
                     try:
-                      logger.debug("Finding vehicle's checkbox")  
-                      checkbox = browser.find_element_by_xpath('//input[contains(@id, '+ownedVehicle.getID() +')]')                
-                      # Scroll the element
-                      browser.execute_script("arguments[0].scrollIntoView();", checkbox)
-                      checkbox.click()
-                      checkedunits = True     
-                      des+=1
-                      logger.debug("Adding vehicle to despatched list, and setting it as despatched")
-                      despatchedVehicles.append(ownedVehicle.getID())   
-                      ownedVehicle.setDespatched()       
+                      logger.debug("Finding vehicle's checkbox" + ownedVehicle.getID())  
+                      # Confirm element exists
+                      if browser.find_element_by_xpath('//input[contains(@id, '+ownedVehicle.getID() +')]'):  
+                        logger.debug("There is a checkbox with the id "+ownedVehicle.getID() )
+                        checkbox = browser.find_element_by_xpath('//input[contains(@id, '+ownedVehicle.getID() +')]')        
+                        wait = WebDriverWait(browser, 60)
+                        obj = wait.until(EC.presence_of_element_located((By.XPATH, '//input[contains(@id, '+ownedVehicle.getID() +')]')))
+                        # Scroll to the element
+                        browser.execute_script("return arguments[0].scrollIntoView();", checkbox)
+                        logger.debug("Attempting to click " + ownedVehicle.getID())  
+                        try: 
+                          checkbox.click()
+                          logger.debug(ownedVehicle.getID() + " was clicked")  
+                          checkedunits = True     
+                          des+=1
+                          logger.debug("Adding vehicle to despatched list, and setting it as despatched")
+                          despatchedVehicles.append(ownedVehicle.getID())   
+                          ownedVehicle.setDespatched()       
+                        except ElementClickInterceptedException as e:
+                          # Throws if it cant click the checkbox, as element is covering etc. Just continue.
+                          logger.debug(ownedVehicle.getID() + " was not clicked error ")  
+                          continue
+                      else:
+                       logger.debug(ownedVehicle.getID() + " could not find checkbox at all- skipping ")  
+                       continue
                     except (NoSuchElementException) as e: 
                       logger.error("Vehicle checkbox cannot be found, or clicked" + ownedVehicle.getID())
                       continue