Skip to content

Commit 3f85dd4

Browse files
committed
Send cookies one time
MyCookieJar's extra cookies are not associated with an explicity url, as they probably should be. Therefore, the cookies need to be cleared before loading more cookies or we'll have all cookies for all urls sent, which is redundent.
1 parent f31f7f0 commit 3f85dd4

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

src/lib/multipageloader.cc

+5
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,7 @@ void ResourceObject::load() {
451451
}
452452

453453

454+
multiPageLoader.cookieJar->clearExtraCookies();
454455
typedef QPair<QString, QString> SSP;
455456
foreach (const SSP & pair, settings.cookies)
456457
multiPageLoader.cookieJar->useCookie(url, pair.first, pair.second);
@@ -469,6 +470,10 @@ void ResourceObject::load() {
469470
}
470471
}
471472

473+
void MyCookieJar::clearExtraCookies() {
474+
extraCookies.clear();
475+
}
476+
472477
void MyCookieJar::useCookie(const QUrl &, const QString & name, const QString & value) {
473478
extraCookies.push_back(QNetworkCookie(name.toUtf8(), value.toUtf8()));
474479
}

src/lib/multipageloader_p.hh

+1
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ class DLL_LOCAL MyCookieJar: public QNetworkCookieJar {
112112
private:
113113
QList<QNetworkCookie> extraCookies;
114114
public:
115+
void clearExtraCookies();
115116
void useCookie(const QUrl & url, const QString & name, const QString & value);
116117
QList<QNetworkCookie> cookiesForUrl(const QUrl & url) const;
117118
void loadFromFile(const QString & path);

0 commit comments

Comments
 (0)