lint, vet and docs

Author: TwistedHardware

Diff for: abtest.go

@@ -8,12 +8,15 @@ import (
 	"time"
 )
 
+// ABTestType is the type of the AB testing: model or static
 type ABTestType int
 
+// Static is used to do AB testing for static assets (images, js, css, ...)
 func (ABTestType) Static() ABTestType {
 	return 1
 }
 
+// Model is used to do AB testing for model values coming from database
 func (ABTestType) Model() ABTestType {
 	return 2
 }

Diff for: abtest_value.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 )
 
+// ABTestValue is a model to represent a possible value of an AB test
 type ABTestValue struct {
 	Model
 	ABTest      ABTest
@@ -20,17 +21,21 @@ func (a *ABTestValue) String() string {
 	return a.Value
 }
 
+// ClickThroughRate returns the rate of click through of this value
 func (a *ABTestValue) ClickThroughRate() float64 {
 	if a.Impressions == 0 {
 		return 0.0
 	}
 	return float64(a.Clicks) / float64(a.Impressions) * 100
 }
 
+// ClickThroughRate__Form__List shows the click through rate in form
+// and list views
 func (a ABTestValue) ClickThroughRate__Form__List() string {
 	return fmt.Sprintf("<b>%.2f%%</b>", a.ClickThroughRate())
 }
 
+// Preview__Form__List shows a preview of the AB test's value
 func (a ABTestValue) Preview__Form__List() string {
 	// Check if the value is a path to a file
 	if strings.HasPrefix(a.Value, "/") {
@@ -48,6 +53,7 @@ func (a ABTestValue) Preview__Form__List() string {
 	return a.Value
 }
 
+// HideInDashboard to hide it from dashboard
 func (ABTestValue) HideInDashboard() bool {
 	return true
 }

Diff for: auth.go

@@ -27,7 +27,7 @@ var bcryptDiff = 12
 // cachedSessions is variable for keeping active sessions
 var cachedSessions map[string]Session
 
-// invalidAttemps keeps track of invalid password attemps
+// invalidAttemps keeps track of invalid password attempts
 // per IP address
 var invalidAttempts = map[string]int{}
 

Diff for: d_api_add.go

@@ -81,7 +81,7 @@ func dAPIAddHandler(w http.ResponseWriter, r *http.Request, s *Session) {
 		for i := range q {
 			// Build args place holder
 			argsPlaceHolder := []string{}
-			for _ = range args[i] {
+			for range args[i] {
 				argsPlaceHolder = append(argsPlaceHolder, "?")
 			}
 

Diff for: d_api_helper.go

@@ -192,30 +192,26 @@ func getQueryOperator(r *http.Request, v string, tableName string) string {
 	if strings.HasSuffix(v, "__gt") {
 		if n {
 			return strings.TrimSuffix(v, "__gt") + "` <= ?"
-		} else {
-			return strings.TrimSuffix(v, "__gt") + "` > ?"
 		}
+		return strings.TrimSuffix(v, "__gt") + "` > ?"
 	}
 	if strings.HasSuffix(v, "__gte") {
 		if n {
 			return strings.TrimSuffix(v, "__gte") + "` < ?"
-		} else {
-			return strings.TrimSuffix(v, "__gte") + "` >= ?"
 		}
+		return strings.TrimSuffix(v, "__gte") + "` >= ?"
 	}
 	if strings.HasSuffix(v, "__lt") {
 		if n {
 			return strings.TrimSuffix(v, "__lt") + "` >= ?"
-		} else {
-			return strings.TrimSuffix(v, "__lt") + "` < ?"
 		}
+		return strings.TrimSuffix(v, "__lt") + "` < ?"
 	}
 	if strings.HasSuffix(v, "__lte") {
 		if n {
 			return strings.TrimSuffix(v, "__lte") + "` > ?"
-		} else {
-			return strings.TrimSuffix(v, "__lte") + "` <= ?"
 		}
+		return strings.TrimSuffix(v, "__lte") + "` <= ?"
 	}
 	if strings.HasSuffix(v, "__in") {
 		return strings.TrimSuffix(v, "__in") + nTerm + "` IN (?)"
@@ -278,9 +274,8 @@ func getQueryArg(k, v string) []interface{} {
 	if strings.HasSuffix(k, "__is") {
 		if strings.ToUpper(v) == "NULL" {
 			return []interface{}{interface{}(nil)}
-		} else {
-			return []interface{}{v}
 		}
+		return []interface{}{v}
 	}
 	if strings.HasSuffix(k, "__contains") {
 		return []interface{}{"%" + v + "%"}
@@ -667,102 +662,137 @@ func returnDAPIJSON(w http.ResponseWriter, r *http.Request, a map[string]interfa
 	return nil
 }
 
+// APILogReader is an interface for models to control loggin their read function in dAPI
 type APILogReader interface {
 	APILogRead(*http.Request) bool
 }
 
+// APILogEditor is an interface for models to control loggin their edit function in dAPI
 type APILogEditor interface {
 	APILogEdit(*http.Request) bool
 }
 
+// APILogAdder is an interface for models to control loggin their add function in dAPI
 type APILogAdder interface {
 	APILogAdd(*http.Request) bool
 }
 
+// APILogDeleter is an interface for models to control loggin their delete function in dAPI
 type APILogDeleter interface {
 	APILogDelete(*http.Request) bool
 }
 
+// APILogSchemer is an interface for models to control loggin their schema function in dAPI
 type APILogSchemer interface {
 	APILogSchema(*http.Request) bool
 }
 
+// APIPublicReader is an interface for models to control public access to read function in dAPI
 type APIPublicReader interface {
 	APIPublicRead(*http.Request) bool
 }
 
+// APIPublicEditor is an interface for models to control public access to read function in dAPI
 type APIPublicEditor interface {
 	APIPublicEdit(*http.Request) bool
 }
 
+// APIPublicAdder is an interface for models to control public access to add function in dAPI
 type APIPublicAdder interface {
 	APIPublicAdd(*http.Request) bool
 }
 
+// APIPublicDeleter is an interface for models to control public access to delete function in dAPI
 type APIPublicDeleter interface {
 	APIPublicDelete(*http.Request) bool
 }
 
+// APIPublicSchemer is an interface for models to control public access to schema function in dAPI
 type APIPublicSchemer interface {
 	APIPublicSchema(*http.Request) bool
 }
 
+// APIDisabledReader is an interface for models to disable access to read function in dAPI
 type APIDisabledReader interface {
 	APIDisabledRead(*http.Request) bool
 }
 
+// APIDisabledEditor is an interface for models to disable access to edit function in dAPI
 type APIDisabledEditor interface {
 	APIDisabledEdit(*http.Request) bool
 }
 
+// APIDisabledAdder is an interface for models to disable access to add function in dAPI
 type APIDisabledAdder interface {
 	APIDisabledAdd(*http.Request) bool
 }
 
+// APIDisabledDeleter is an interface for models to disable access to delete function in dAPI
 type APIDisabledDeleter interface {
 	APIDisabledDelete(*http.Request) bool
 }
 
+// APIDisabledSchemer is an interface for models to disable access to schema function in dAPI
 type APIDisabledSchemer interface {
 	APIDisabledSchema(*http.Request) bool
 }
 
+// APIPreQueryReader is an interface for models to run before processing read function in dAPI.
+// Returning false stops the rest of the process from happening
 type APIPreQueryReader interface {
 	APIPreQueryRead(http.ResponseWriter, *http.Request) bool
 }
 
+// APIPostQueryReader is an interface for models to run after processing read function in dAPI
+// and before returning the results. Returning false stops the rest of the process from happening
 type APIPostQueryReader interface {
 	APIPostQueryRead(http.ResponseWriter, *http.Request, map[string]interface{}) bool
 }
 
+// APIPreQueryAdder is an interface for models to run before processing add function in dAPI.
+// Returning false stops the rest of the process from happening
 type APIPreQueryAdder interface {
 	APIPreQueryAdd(http.ResponseWriter, *http.Request) bool
 }
 
+// APIPostQueryAdder is an interface for models to run after processing add function in dAPI
+// and before returning the results. Returning false stops the rest of the process from happening
 type APIPostQueryAdder interface {
 	APIPostQueryAdd(http.ResponseWriter, *http.Request, map[string]interface{}) bool
 }
 
+// APIPreQueryEditor is an interface for models to run before processing edit function in dAPI.
+// Returning false stops the rest of the process from happening
 type APIPreQueryEditor interface {
 	APIPreQueryEdit(http.ResponseWriter, *http.Request) bool
 }
 
+// APIPostQueryEditor is an interface for models to run after processing edit function in dAPI
+// and before returning the results. Returning false stops the rest of the process from happening
 type APIPostQueryEditor interface {
 	APIPostQueryEdit(http.ResponseWriter, *http.Request, map[string]interface{}) bool
 }
 
+// APIPreQueryDeleter is an interface for models to run before processing delete function in dAPI.
+// Returning false stops the rest of the process from happening
 type APIPreQueryDeleter interface {
 	APIPreQueryDelete(http.ResponseWriter, *http.Request) bool
 }
 
+// APIPostQueryDeleter is an interface for models to run after processing delete function in dAPI
+// and before returning the results. Returning false stops the rest of the process from happening
 type APIPostQueryDeleter interface {
 	APIPostQueryDelete(http.ResponseWriter, *http.Request, map[string]interface{}) bool
 }
 
+// APIPreQuerySchemer is an interface for models to run before processing schema function in dAPI.
+// Returning false stops the rest of the process from happening
 type APIPreQuerySchemer interface {
 	APIPreQuerySchema(http.ResponseWriter, *http.Request) bool
 }
 
+// APIPostQuerySchemer is an interface for models to run after processing schema function in dAPI
+// and before returning the results. Returning false stops the rest of the process from happening
 type APIPostQuerySchemer interface {
 	APIPostQuerySchema(http.ResponseWriter, *http.Request, map[string]interface{}) bool
 }

Diff for: d_api_schema.go

@@ -2,9 +2,10 @@ package uadmin
 
 import (
 	"encoding/json"
-	"github.com/jinzhu/gorm"
 	"net/http"
 	"strings"
+
+	"github.com/jinzhu/gorm"
 )
 
 func dAPISchemaHandler(w http.ResponseWriter, r *http.Request, s *Session) {
@@ -45,10 +46,12 @@ func dAPISchemaHandler(w http.ResponseWriter, r *http.Request, s *Session) {
 
 	// Get Language
 	lang := r.URL.Query().Get("language")
-	if langC, err := r.Cookie("language"); err != nil || (langC != nil && langC.Value == "") {
-		lang = GetDefaultLanguage().Code
-	} else {
-		lang = langC.Value
+	if lang == "" {
+		if langC, err := r.Cookie("language"); err != nil || (langC != nil && langC.Value == "") {
+			lang = GetDefaultLanguage().Code
+		} else {
+			lang = langC.Value
+		}
 	}
 
 	// Translation