Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect config generated by config-ssh #425

Open
code-asher opened this issue Jan 22, 2025 · 2 comments
Open

Respect config generated by config-ssh #425

code-asher opened this issue Jan 22, 2025 · 2 comments

Comments

@code-asher
Copy link
Member

code-asher commented Jan 22, 2025

I am not sure how feasible this is, but it seems more doable now that config-ssh uses wildcards. We generate a separate config because we want to add flags and options. Maybe we could read the SSH config and add anything we are missing? Would need to respect CODER_SSH_CONFIG_FILE as well.

Or, can we do something with includes? Or if we use a prefix like coder.vscode.* then it will just naturally inherit options.

@coder-labeler coder-labeler bot added the help wanted Extra attention is needed label Jan 22, 2025
@code-asher code-asher removed the help wanted Extra attention is needed label Jan 22, 2025
@matifali
Copy link
Member

matifali commented Apr 3, 2025

We now use wildcard configs as per version 1.4.0. This should be fixed. If not, please comment/reopen.

@matifali matifali closed this as completed Apr 3, 2025
@code-asher
Copy link
Member Author

code-asher commented Apr 3, 2025

The problem was that users would do things like coder config-ssh -o ForwardX11=yes and ForwardX11=yes will apply to coder ssh or ssh coder.* but it will not apply to the extension, wildcards or no.

It can be worked around by manually adding ForwardX11=yes to the SSH config file or the extension settings, but it could be nice to support it automatically. Not sure how many people care about this though.

@matifali matifali reopened this Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants