From bd085a43a7a41fa773be4271b8638be353fb047d Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Fri, 9 May 2025 13:37:30 -0500 Subject: [PATCH 1/2] fix: allow dropdown form_type for boolean types --- provider/formtype.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provider/formtype.go b/provider/formtype.go index 75d32c46..931179da 100644 --- a/provider/formtype.go +++ b/provider/formtype.go @@ -99,7 +99,7 @@ var formTypeTruthTable = map[OptionType]map[bool][]ParameterFormType{ false: {ParameterFormTypeInput, ParameterFormTypeSlider}, }, OptionTypeBoolean: { - true: {ParameterFormTypeRadio}, + true: {ParameterFormTypeRadio, ParameterFormTypeDropdown}, false: {ParameterFormTypeCheckbox, ParameterFormTypeSwitch}, }, OptionTypeListString: { From 322046acfea1316b40dd3ce0277b050cde3e878f Mon Sep 17 00:00:00 2001 From: Steven Masley Date: Mon, 12 May 2025 07:57:12 -0500 Subject: [PATCH 2/2] add dropdown boolean test --- provider/formtype_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/provider/formtype_test.go b/provider/formtype_test.go index eaf7b587..2f3dff53 100644 --- a/provider/formtype_test.go +++ b/provider/formtype_test.go @@ -193,6 +193,11 @@ func TestValidateFormType(t *testing.T) { optionType: provider.OptionTypeBoolean, formType: provider.ParameterFormTypeRadio, }), + expectSameFormType(formTypeCheck{ + options: true, + optionType: provider.OptionTypeBoolean, + formType: provider.ParameterFormTypeDropdown, + }), expectSameFormType(formTypeCheck{ options: false, optionType: provider.OptionTypeBoolean,