fix #167 use latest version of code-server #182
Conversation
| @@ -21,7 +22,7 @@ import ( | |||
| "golang.org/x/xerrors" | |||
| ) | |||
|
|
|||
| const codeServerPath = "~/.cache/sshcode/sshcode-server" | |||
| const codeServerDir = "~/.sshcode-server" | |||
There was a problem hiding this comment.
I've made this directory change so it is similar to how .vscode-server stores itself. Also a lot of other tools do the same - nvm, npm, docker, cocoapods and etc.
Hopefully this will make sense.
| codeServerFlags := []string{ | ||
| fmt.Sprintf("--bind-addr 127.0.0.1:%v", o.remotePort), | ||
| "--auth none", | ||
| } | ||
| codeServerCmdStr := fmt.Sprintf("%v/code-server %v %v", codeServerDir, dir, strings.Join(codeServerFlags, " ")) |
There was a problem hiding this comment.
This change is mostly a groundwork for #178 which I will resubmit (with additional changes I've discovered necessary) after this PR get merged.
|
@nhooyr would you mind taking a look? |
|
there is a button on the side that requests a reveiw. or down below here, i forgot |
|
I do not see any button. There is a section on the right side, but I can't use it. Maybe you can because you have collaborator status? |
gyzerok
force-pushed
the
use-latest-code-server
branch
from
454b7d3
to
f96bdd5
Compare
|
@gyzerok Thanks for contributing, sorry for the late response. I'll take a look at this soon. |
|
It seems that after 3.3.0 update it got broken for my environment at least. So I invite you to help me figure out the most proper solution before we merge it. I am willing to incorporate any suggestions to make it the best experience for others. Zero idea what it's about, but maybe you can help - |
gyzerok
force-pushed
the
use-latest-code-server
branch
from
f96bdd5
to
91bfd17
Compare
|
@gyzerok Can you hold off on further work here? We're discussing deprecating |
|
@nhooyr |
|
@Merith-TK Yup, sorry I meant a shell script. |
|
@nhooyr right now no further work is happening. I just have added ability to pass additional flags to the Thanks for notifying me. Will be awaiting for you decision :) |
|
See #185 |
Hello!
This PR fixes #167
There was a bit of a jungle with #178 and #181, so let me explain what happened.
Big thanks to @Merith-TK I realized, that the different PR order would make more sense. However we misunderstood each other a bit with the PR openings. Anyway - everything is clear now, so I am making the PRs in the right order. My apologies for the PR jungling :)