Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor installer to be a PKG #83

Closed
ThomasK33 opened this issue Feb 27, 2025 · 2 comments · Fixed by #92
Closed

Refactor installer to be a PKG #83

ThomasK33 opened this issue Feb 27, 2025 · 2 comments · Fixed by #92
Assignees
@ThomasK33 @spikecurtis
Labels
bug Something isn't working

Comments

@ThomasK33
Copy link
Member

We are currently experiencing issues with the installation and upgrade of Coder Desktop. Specifically, we are encountering this issue, where some component of macOS becomes confused during an update, resulting in a faulty state for both us and the operating system.

We must refactor our installation method to use a package with a pre-install script. This script should:

  • Shut down the network extension
  • Shut down the desktop client
  • Check for any existing Homebrew installations (multiple installations of the network extension can cause issues on macOS)

Implementing these steps should help prevent any disruptions during upgrades.
@ThomasK33 ThomasK33 added the bug Something isn't working label Feb 27, 2025
@ThomasK33 ThomasK33 self-assigned this Feb 27, 2025
@ethanndickson
Copy link
Member

ethanndickson commented Mar 6, 2025 •
edited
Loading

More relevant threads on the weird behaviour we've been seeing:
https://developer.apple.com/forums/thread/711713 (from above)
https://developer.apple.com/forums/thread/667597
https://developer.apple.com/forums/thread/742992
https://developer.apple.com/forums/thread/728063?answerId=751243022#751243022

Essentially, on-upgrade, the app becomes unable to communicate with the network extension.
This can lead to a incorrect UI state:

Image

Or consistent errors on functionality that requires communcation between the two, such as:

Image

@ThomasK33 ThomasK33 linked a pull request Mar 6, 2025 that will close this issue
fix(build): switch to pkg based installer #92
Merged
@ethanndickson ethanndickson mentioned this issue Mar 13, 2025
Merged
ethanndickson added a commit that referenced this issue Mar 18, 2025
@ethanndickson
chore(pkgbuild): delete existing app during preinstall, `spctl --asse…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6947811 
…ss` during postinstall (#112)

Relates to #83.

It looks like deleting the app does indeed kill the NE process, so we should do that during `preinstall`.

In case the XPC issue we've been seeing is due to a race between the app being opened, and Gatekeeper ingesting the notarization ticket, we'll also force Gatekeeper to read the ticket by running `spctl -a` on the app bundle, and the extension bundle. The latter always fails, but an attempt to read it can't hurt.
@ethanndickson ethanndickson mentioned this issue Mar 25, 2025
Open
@ethanndickson
Copy link
Member

Issue succeeded by #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasK33 ThomasK33

@spikecurtis spikecurtis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): switch to pkg based installer coder/coder-desktop-macos
3 participants
@ThomasK33 @spikecurtis @ethanndickson