Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codemod][FP] styledictionary/4/instantiating-style-dictionary updates extend even if its not from Style Dictionary #1328

Open
alexbit-codemod opened this issue Sep 20, 2024 · 1 comment · May be fixed by #1329
Open

[codemod][FP] styledictionary/4/instantiating-style-dictionary updates extend even if its not from Style Dictionary #1328

alexbit-codemod opened this issue Sep 20, 2024 · 1 comment · May be fixed by #1329
Labels
codemod-issue Any issues related to a codemod, FP or FN. false positive

Comments

@alexbit-codemod
Copy link
Contributor

Faulty codemod

Screenshot 2024-09-19 at 5 19 57 PM

  1. npx codemod styledictionary/4/instantiating-style-dictionary
  2. upgrade guide

Sample code snippets

Screenshot 2024-09-19 at 5 22 12 PM

it seems that extend is being transformed even if its not coming from style dictionary.
@alexbit-codemod alexbit-codemod added the codemod-issue Any issues related to a codemod, FP or FN. label Sep 20, 2024
@alexbit-codemod alexbit-codemod changed the title [codemod][FP] <codemod-name> [codemod][FP] styledictionary/4/instantiating-style-dictionary updates extend even if its not from Style Dictionary Sep 20, 2024
@alexbit-codemod
Copy link
Contributor Author

this is the codemod akshit built: https://go.codemod.com/pJCX81f
seems that it works fine. but the one that is published does not work properly. maybe we just need to publish the latest version?

@AkshitGarg24 AkshitGarg24 linked a pull request Sep 22, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codemod-issue Any issues related to a codemod, FP or FN. false positive
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

updated styledictionary/4/asynchronous-api codemod AkshitGarg24/codemod
1 participant
@alexbit-codemod