diff --git a/CHANGELOG.md b/CHANGELOG.md index fed4c4c8..40bbe6de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,9 @@ Version 0.54.3 **Bugfixes** - Support device class `APPLE_SILICON_MAC` on App Store Connect API [`Device`](https://developer.apple.com/documentation/appstoreconnectapi/device) responses. [PR #437](https://github.com/codemagic-ci-cd/cli-tools/pull/437) +**Improvements** +- Fail action `app-store-connect fetch-signing-files` early with descriptive error message if bundle ID identifier is not given. [PR #438](https://github.com/codemagic-ci-cd/cli-tools/pull/438) + Version 0.54.2 ------------- diff --git a/src/codemagic/tools/app_store_connect/actions/fetch_signing_files_action.py b/src/codemagic/tools/app_store_connect/actions/fetch_signing_files_action.py index 5f7484c4..083fec74 100644 --- a/src/codemagic/tools/app_store_connect/actions/fetch_signing_files_action.py +++ b/src/codemagic/tools/app_store_connect/actions/fetch_signing_files_action.py @@ -59,6 +59,11 @@ def fetch_signing_files( for Bundle ID with given identifier """ + if not bundle_id_identifier: + raise BundleIdArgument.BUNDLE_ID_IDENTIFIER.raise_argument_error( + 'Bundle ID identifier must be specified, empty values are not allowed. For example "com.example.app".', + ) + private_key = self._get_certificate_key(certificate_key, certificate_key_password) if private_key is None: raise AppStoreConnectError(f"Cannot save {SigningCertificate.s} without certificate private key")