Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C2LC-442: Fix KeyboardShortcuts modal icon zooming issue in Firefox #237

Open
wants to merge 1 commit into
base: develop-1.0
Choose a base branch
from

Conversation

chosww
Copy link
Contributor

@chosww chosww commented Aug 25, 2021

See C2LC-442 for details.

@the-t-in-rtf
Copy link
Contributor

Nearly everything scales consistently with the changes here. Not sure if we want to fix this here, or in another pull, but there are a few remaining issues when "zoom text only" is checked:

  1. The character icon in the scene does not scale.
  2. The grid cells don't scale.
  3. The character icon in the program block editor escapes its background when scaling (say to 200%).
  4. The plus sign in an expanded add node escapes its bound as well.

See screenshot of points 3 and 4.

Screenshot 2021-08-26 at 09 45 01

Those are my notes from testing Firefox, I'll comment separately on other browsers in a few minutes.

@the-t-in-rtf
Copy link
Contributor

Everything scales appropriately and consistently in Chrome and Safari (in both OS X and the iOS simulator). The points I highlighted above work as I'd expect in other browsers, i.e.:

  1. The character icon in the scene scales when zooming.
  2. The grid cells scale when zooming.
  3. The character icon in the program block editor and its background scale together.
  4. The plus sign and circle of the expanded add node scale together.

We should talk with Simon about whether we want to rework this issue to be very slightly larger, or break out the remaining fixes. I'd argue for the first, as the testing is very similar for all these issues.

@chosww
Copy link
Contributor Author

chosww commented Aug 26, 2021

Yeah, I agree that we should rework this issue in a bit larger scale. Also, zooming out also causes some problems to more components than you have noted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When "zoom text only" is checked in Firefox, some icons do not scale
2 participants