From 91fea1a0543b5a5cd49a2087a2db3fc2fcfed9ee Mon Sep 17 00:00:00 2001 From: kenjis Date: Tue, 5 Mar 2024 09:32:27 +0900 Subject: [PATCH 1/2] refactor: remove unnecessary $services assignment --- system/Config/BaseService.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/system/Config/BaseService.php b/system/Config/BaseService.php index aeb0e854427c..3db319d8d8f1 100644 --- a/system/Config/BaseService.php +++ b/system/Config/BaseService.php @@ -167,6 +167,8 @@ class BaseService * A cache of other service classes we've found. * * @var array + * + * @deprecated 4.5.0 No longer used. */ protected static $services = []; @@ -335,7 +337,6 @@ protected static function buildServicesCache(): void if ($classname !== Services::class) { self::$serviceNames[] = $classname; - static::$services[] = new $classname(); } } } From 3c719133caa0da4c35e43b01eaf5fea94663197b Mon Sep 17 00:00:00 2001 From: kenjis Date: Tue, 5 Mar 2024 09:37:23 +0900 Subject: [PATCH 2/2] docs: add changelog --- user_guide_src/source/changelogs/v4.5.0.rst | 2 ++ 1 file changed, 2 insertions(+) diff --git a/user_guide_src/source/changelogs/v4.5.0.rst b/user_guide_src/source/changelogs/v4.5.0.rst index fe3a78534cea..11c5a755c0ad 100644 --- a/user_guide_src/source/changelogs/v4.5.0.rst +++ b/user_guide_src/source/changelogs/v4.5.0.rst @@ -450,6 +450,8 @@ Deprecations - **CodeIgniter:** The ``determinePath()`` method has been deprecated. No longer used. +- **Services:** The ``BaseService::$services`` property has been deprecated. No + longer used. - **Response:** The constructor parameter ``$config`` has been deprecated. No longer used. - **Filters:**