From aa78c32f7e7474a5483185be4c74ea40d40b7275 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 21 Dec 2023 15:17:28 +0000 Subject: [PATCH 001/148] chore(deps): bump actions/download-artifact from 3 to 4 Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](https://github.com/actions/download-artifact/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/reusable-coveralls.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reusable-coveralls.yml b/.github/workflows/reusable-coveralls.yml index a5dfc83996cb..32415f80a602 100644 --- a/.github/workflows/reusable-coveralls.yml +++ b/.github/workflows/reusable-coveralls.yml @@ -24,7 +24,7 @@ jobs: coverage: xdebug - name: Download coverage files - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: path: build/cov From 19a54ba666858716e9e083ed44c01925b210d6df Mon Sep 17 00:00:00 2001 From: kenjis Date: Thu, 28 Dec 2023 20:15:29 +0900 Subject: [PATCH 002/148] docs: add changelog and upgrade for v4.4.5 --- user_guide_src/source/changelogs/index.rst | 1 + user_guide_src/source/changelogs/v4.4.5.rst | 35 ++++++++++++ .../source/installation/upgrade_445.rst | 54 +++++++++++++++++++ .../source/installation/upgrading.rst | 1 + 4 files changed, 91 insertions(+) create mode 100644 user_guide_src/source/changelogs/v4.4.5.rst create mode 100644 user_guide_src/source/installation/upgrade_445.rst diff --git a/user_guide_src/source/changelogs/index.rst b/user_guide_src/source/changelogs/index.rst index eb9f7f1f5edb..a8dc37b18aa6 100644 --- a/user_guide_src/source/changelogs/index.rst +++ b/user_guide_src/source/changelogs/index.rst @@ -12,6 +12,7 @@ See all the changes. .. toctree:: :titlesonly: + v4.4.5 v4.4.4 v4.4.3 v4.4.2 diff --git a/user_guide_src/source/changelogs/v4.4.5.rst b/user_guide_src/source/changelogs/v4.4.5.rst new file mode 100644 index 000000000000..e029a1d9f3a5 --- /dev/null +++ b/user_guide_src/source/changelogs/v4.4.5.rst @@ -0,0 +1,35 @@ +############# +Version 4.4.5 +############# + +Release Date: Unreleased + +**4.4.5 release of CodeIgniter4** + +.. contents:: + :local: + :depth: 3 + +******** +BREAKING +******** + +*************** +Message Changes +*************** + +******* +Changes +******* + +************ +Deprecations +************ + +********** +Bugs Fixed +********** + +See the repo's +`CHANGELOG.md `_ +for a complete list of bugs fixed. diff --git a/user_guide_src/source/installation/upgrade_445.rst b/user_guide_src/source/installation/upgrade_445.rst new file mode 100644 index 000000000000..48273f86da62 --- /dev/null +++ b/user_guide_src/source/installation/upgrade_445.rst @@ -0,0 +1,54 @@ +############################# +Upgrading from 4.4.4 to 4.4.5 +############################# + +Please refer to the upgrade instructions corresponding to your installation method. + +- :ref:`Composer Installation App Starter Upgrading ` +- :ref:`Composer Installation Adding CodeIgniter4 to an Existing Project Upgrading ` +- :ref:`Manual Installation Upgrading ` + +.. contents:: + :local: + :depth: 2 + +********************** +Mandatory File Changes +********************** + +**************** +Breaking Changes +**************** + +********************* +Breaking Enhancements +********************* + +************* +Project Files +************* + +Some files in the **project space** (root, app, public, writable) received updates. Due to +these files being outside of the **system** scope they will not be changed without your intervention. + +There are some third-party CodeIgniter modules available to assist with merging changes to +the project space: `Explore on Packagist `_. + +Content Changes +=============== + +The following files received significant changes (including deprecations or visual adjustments) +and it is recommended that you merge the updated versions with your application: + +Config +------ + +- @TODO + +All Changes +=========== + +This is a list of all files in the **project space** that received changes; +many will be simple comments or formatting that have no effect on the runtime: + +- @TODO diff --git a/user_guide_src/source/installation/upgrading.rst b/user_guide_src/source/installation/upgrading.rst index 2c0731f3a437..b11fbfc92cfb 100644 --- a/user_guide_src/source/installation/upgrading.rst +++ b/user_guide_src/source/installation/upgrading.rst @@ -16,6 +16,7 @@ See also :doc:`./backward_compatibility_notes`. backward_compatibility_notes + upgrade_445 upgrade_444 upgrade_443 upgrade_442 From 4f4b969f71d8587df9ea0a99baef3bf8ee9ca3e6 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 29 Dec 2023 08:43:46 +0900 Subject: [PATCH 003/148] docs: add instruction to merge develop into 4.x --- admin/RELEASE.md | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/admin/RELEASE.md b/admin/RELEASE.md index 8d68ccd9923a..b168f7856354 100644 --- a/admin/RELEASE.md +++ b/admin/RELEASE.md @@ -6,7 +6,21 @@ > > -MGatner, kenjis -## [Minor version only] Merge minor version branch into develop +## Merge `develop` branch into next minor version branch `4.x` + +Before starting release process, if there are commits in `develop` branch that +are not merged into `4.x` branch, merge them. This is because if conflicts occur, +merging will take time. + +```console +git fetch upstream +git switch 4.x +git merge upstream/4.x +git merge upstream/develop +git push upstream HEAD +``` + +## [Minor version only] Merge minor version branch into `develop` If you release a new minor version. @@ -149,7 +163,7 @@ Work off direct clones of the repos so the release branches persist for a time. git merge origin/master git push origin HEAD ``` -* [ ] Update the next minor upgrade branch `4.x`: +* [ ] Update the next minor version branch `4.x`: ```console git fetch origin git checkout 4.x @@ -157,7 +171,7 @@ Work off direct clones of the repos so the release branches persist for a time. git merge origin/develop git push origin HEAD ``` -* [ ] [Minor version only] Create the next minor upgrade branch `4.x`: +* [ ] [Minor version only] Create the new next minor version branch `4.x`: ```console git fetch origin git switch develop From 43f3da3de907b9b24d745d4902c272e40449ab95 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 29 Dec 2023 09:22:24 +0900 Subject: [PATCH 004/148] docs: fix section title level --- user_guide_src/source/changelogs/v4.4.4.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/user_guide_src/source/changelogs/v4.4.4.rst b/user_guide_src/source/changelogs/v4.4.4.rst index e7990adf9173..409ef9361830 100644 --- a/user_guide_src/source/changelogs/v4.4.4.rst +++ b/user_guide_src/source/changelogs/v4.4.4.rst @@ -39,6 +39,7 @@ Filesystem Helper :php:func:`get_filenames()` now follows symlink folders, which it previously just returned without following. +************ Enhancements ************ From e5331d432454de3e9f0294dadac10dea199095a8 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 29 Dec 2023 09:36:00 +0900 Subject: [PATCH 005/148] chore: update php-cs-fixer version --- admin/framework/composer.json | 2 +- composer.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/admin/framework/composer.json b/admin/framework/composer.json index 9d7cba44ddbb..e50d6445aba4 100644 --- a/admin/framework/composer.json +++ b/admin/framework/composer.json @@ -20,7 +20,7 @@ "require-dev": { "codeigniter/coding-standard": "^1.5", "fakerphp/faker": "^1.9", - "friendsofphp/php-cs-fixer": "~3.41.0", + "friendsofphp/php-cs-fixer": "^3.43", "kint-php/kint": "^5.0.4", "mikey179/vfsstream": "^1.6", "nexusphp/cs-config": "^3.6", diff --git a/composer.json b/composer.json index f7f98d862c11..0b3a49f8c6ba 100644 --- a/composer.json +++ b/composer.json @@ -22,7 +22,7 @@ "codeigniter/phpstan-codeigniter": "^1.4", "ergebnis/composer-normalize": "^2.28", "fakerphp/faker": "^1.9", - "friendsofphp/php-cs-fixer": "~3.41.0", + "friendsofphp/php-cs-fixer": "^3.43", "kint-php/kint": "^5.0.4", "mikey179/vfsstream": "^1.6", "nexusphp/cs-config": "^3.6", From 4b2985ce5edfb15d228ff893c4e69c7ce52e9c0d Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 29 Dec 2023 09:47:27 +0900 Subject: [PATCH 006/148] chore: add fully_qualified_strict_types config Do not process @see tag. See https://cs.symfony.com/doc/rules/import/fully_qualified_strict_types.html --- .php-cs-fixer.dist.php | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/.php-cs-fixer.dist.php b/.php-cs-fixer.dist.php index 8c2a6b8b7a52..13f5ddc63e47 100644 --- a/.php-cs-fixer.dist.php +++ b/.php-cs-fixer.dist.php @@ -67,6 +67,31 @@ 'use', ], ], + 'fully_qualified_strict_types' => [ + 'import_symbols' => false, + 'leading_backslash_in_global_namespace' => false, + 'phpdoc_tags' => [ + 'param', + 'phpstan-param', + 'phpstan-property', + 'phpstan-property-read', + 'phpstan-property-write', + 'phpstan-return', + 'phpstan-var', + 'property', + 'property-read', + 'property-write', + 'psalm-param', + 'psalm-property', + 'psalm-property-read', + 'psalm-property-write', + 'psalm-return', + 'psalm-var', + 'return', + 'throws', + 'var', + ], + ], ]; $options = [ From a12d8d8dcb1f1d15497992ef1ef15324fcf41d31 Mon Sep 17 00:00:00 2001 From: kenjis Date: Fri, 29 Dec 2023 09:49:04 +0900 Subject: [PATCH 007/148] docs: composer cs-fix --- system/Debug/Toolbar/Views/toolbar.tpl.php | 32 +++++++++---------- system/Exceptions/FrameworkException.php | 2 +- user_guide_src/source/models/entities/018.php | 2 +- 3 files changed, 18 insertions(+), 18 deletions(-) diff --git a/system/Debug/Toolbar/Views/toolbar.tpl.php b/system/Debug/Toolbar/Views/toolbar.tpl.php index aadf72ee19ad..3652a536443c 100644 --- a/system/Debug/Toolbar/Views/toolbar.tpl.php +++ b/system/Debug/Toolbar/Views/toolbar.tpl.php @@ -1,21 +1,21 @@