fix: Revert comparison with null

codeigniter4 · Dec 27, 2024 · 0b85e5c · 0b85e5c
1 parent e70ba25
commit 0b85e5c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/system/Common.php b/system/Common.php
@@ -75,7 +75,7 @@ function cache(?string $key = null)
         $cache = service('cache');
 
         // No params - return cache object
-        if ((string) $key === '') {
+        if ($key === null) {
             return $cache;
         }
 
@@ -1128,7 +1128,7 @@ function timer(?string $name = null, ?callable $callable = null)
     {
         $timer = service('timer');
 
-        if ((string) $name === '') {
+        if ($name === null) {
             return $timer;
         }
 

diff --git a/tests/system/Email/EmailTest.php b/tests/system/Email/EmailTest.php
@@ -55,7 +55,7 @@ public function testEmailSendWithClearance($autoClear): void
 
         $this->assertTrue($email->send($autoClear));
 
-        if ($autoClear) {
+        if (! $autoClear) {
             $this->assertSame('[email protected]', $email->archive['recipients'][0]);
         }
     }