Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] - Add notification for inaccessible data #694

Closed
andycwilliams opened this issue Nov 18, 2024 · 2 comments · Fixed by #698
Closed

[Enhancement] - Add notification for inaccessible data #694

andycwilliams opened this issue Nov 18, 2024 · 2 comments · Fixed by #698
Labels
enhancement Enhancement of existing features good first issue Good for newcomers

Comments

@andycwilliams
Copy link
Member

Describe the Current Behavior/Feature:

User 1 gave User 2 access to one of their documents and later revoked access to it. However, User 2 still sees that document in their list. When User 2 then tries to access it, nothing appears to happen. With no feedback they might think something is broken.

Rationale:

There is feedback provided in the console but not for the user themselves. This is neither accessible nor user-friendly design. The user ought to be informed when something does not work as they intended it.

Proposed Changes:

There is already a custom hook called useNotification.js. Import that and alert the user whenever something is no longer accessible.

@andycwilliams andycwilliams added enhancement Enhancement of existing features good first issue Good for newcomers labels Nov 18, 2024
@leekahung
Copy link
Contributor

leekahung commented Nov 18, 2024

Duplicate of Issue #595 relating to docList functionality

@omarNaifer12
Copy link
Contributor

Describe the Current Behavior/Feature:

User 1 gave User 2 access to one of their documents and later revoked access to it. However, User 2 still sees that document in their list. When User 2 then tries to access it, nothing appears to happen. With no feedback they might think something is broken.

Rationale:

There is feedback provided in the console but not for the user themselves. This is neither accessible nor user-friendly design. The user ought to be informed when something does not work as they intended it.

Proposed Changes:

There is already a custom hook called useNotification.js. Import that and alert the user whenever something is no longer accessible.

Hi, I would like to work on this issue. Could you please assign it to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing features good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants