Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] - Fix Failing Tests #662

Closed
12 tasks done
andycwilliams opened this issue Jul 17, 2024 · 9 comments
Closed
12 tasks done

[Bug Report] - Fix Failing Tests #662

andycwilliams opened this issue Jul 17, 2024 · 9 comments
Assignees
@andycwilliams
Labels
bug Something isn't working good first issue Good for newcomers MVP Issues related to MVP

Comments

@andycwilliams
Copy link
Member

andycwilliams commented Jul 17, 2024 •
edited
Loading

Work on this can begin right away. However, it should not be submitted until ensuring there are no additional failing tests from #571 and #606.

Component tests to fix:

  • BasicInfo.test.jsx - Andrew
  • ContactListTable.test.jsx
  • ContactListTableDesktop.test.jsx - Andy
  • ContactListTableMobile.test.jsx - Andy
  • DocumentCard.jsx - Josh
  • DocumentsDesktop.jsx - Josh
  • DocumentsMobile.jsx - Josh
  • HousingInfo.test.jsx - Andrew
  • Messages.test.jsx - Andy
  • PodRegistrationForm.test.jsx
  • Profile.test.jsx - Andrew
  • Signup.test.jsx

Describe the bug:

Some of the tests are now failing.

Expected behavior:

Every test should pass to ensure maximum test coverage possible.

To Reproduce:

Steps to reproduce the behavior:

  1. Run npm run test in the terminal

Additional context:

The tests fail due to changes in the related components. So they should be updated or, when relevant, rewritten according to each component's new specifications. For example, some have been broken up into multiple smaller components and so will need additional tests.

CivicProfile and FinancialInfo are not yet implemented and therefore do not require tests at this time
@andycwilliams andycwilliams added bug Something isn't working good first issue Good for newcomers MVP Issues related to MVP labels Jul 17, 2024
@andycwilliams andycwilliams mentioned this issue Jul 17, 2024
Merged
@andycwilliams
Copy link
Member Author

I've written a few of the tests now but would appreciate some assistance so we can get this done sooner rather than later. I'm not the quickest at these.

@andycwilliams andycwilliams self-assigned this Jul 31, 2024
@AJSterner AJSterner mentioned this issue Jul 31, 2024
Merged
@AJSterner
Copy link
Contributor

I'm fairly sure a bunch of these are timeouts which can be fixed by bumping up the global test timeout time or on a per-test basis.

@AJSterner
Copy link
Contributor

@andycwilliams I may have accidentally fixed them all on #666, take a look.

@AJSterner
Copy link
Contributor

@andycwilliams I don't see any obvious problems with BasicInfo or HousingInfo so I checked them off. Please let me know if there are others you'd like picked up (Profile?).

@AJSterner
Copy link
Contributor

Added my name next to Profile.

@andycwilliams
Copy link
Member Author

Several more tests have been written as of #667. Only a handful more to go.

@andycwilliams
Copy link
Member Author

andycwilliams commented Aug 21, 2024 •
edited
Loading

@AJSterner Any news on tests for Profile? I'm aiming to get MVP wrapped up soon as possible.

@AJSterner AJSterner mentioned this issue Aug 28, 2024
Merged
@AJSterner
Copy link
Contributor

@andycwilliams Profile tests ready for an initial review:
#673

@AJSterner
Copy link
Contributor

Closed out Profile tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andycwilliams andycwilliams

Labels
bug Something isn't working good first issue Good for newcomers MVP Issues related to MVP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AJSterner @andycwilliams