Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] - Vertical scrolling for sign in autocomplete #539

Open
leekahung opened this issue Nov 23, 2023 · 2 comments · Fixed by #541
Open

[Enhancement] - Vertical scrolling for sign in autocomplete #539

leekahung opened this issue Nov 23, 2023 · 2 comments · Fixed by #541
Labels
enhancement Enhancement of existing features good first issue Good for newcomers

Comments

@leekahung
Copy link
Contributor

Describe the Current Behavior/Feature:

Was originally described in #537 (review) this is mainly for the mobile view. But it looks like the issue is somewhat resolved by allowing the modal to stretch instead (see clip).

Screen.Recording.2023-11-22.at.23.52.55.mov

Still think it'll be better if we could keep the modal from changing and allow the autocomplete vertical scroll, but that's just a nit. If there's consensus with this, think we could get this implemented.

Rationale:

Quality of life for mobile version of PASS.

Proposed Implementation (if applicable):

Enable vertical scrolling for the element in question. Could keep the viewable height of the autocomplete list to a fixed height.
@leekahung leekahung added the enhancement Enhancement of existing features label Nov 23, 2023
@rioredwards rioredwards self-assigned this Nov 25, 2023
@rioredwards rioredwards mentioned this issue Nov 25, 2023
Merged
@leekahung leekahung reopened this Nov 27, 2023
@leekahung
Copy link
Contributor Author

Keeping this open fo now.

@timbot1789 timbot1789 added the good first issue Good for newcomers label Apr 11, 2024
@andycwilliams
Copy link
Member

What's the status of this issue now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement of existing features good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add max height for autocomplete and signInModal components codeforpdx/PASS
4 participants
@leekahung @timbot1789 @rioredwards @andycwilliams