-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security HTTP headers? #39
Comments
I don't have a clear opinion on this. I only have the feeling that doing this in two places could be confusing and it is maybe better to set all headers in frontend and backend explicitly without any "magic headers" in traefik.. would love to hear more arguments from more people :) @jdemaeyer maybe 😉 ? |
I also prefer setting common headers in a common place (e.g. in Traefik) rather than re-implementing them in every service. It's nice to have the backend focus on backend business logic, and have stuff like security headers in the reverse proxy, given that that's the part of the system responsible for talking to the outside world |
Let us take a step back and try to compile a list of headers the different services should (or need) to send. The frontend for example shouldn’t send CORS headers. I‘ll update this comment once I have access to a stationary computer |
Good idea
Just an idea: maybe we need some places in frontend where we allow CORS.. guess for now it could be the kiosk view.. maybe later we offer some widgets like That could be the point where we run into problems with generalised headers somewhere else? |
No need for CORS headers for resources loaded by iframe, link or script tags. |
yep but |
#54 will add CSP through a |
I think we should configure our server to send security HTTP headers
This could be done though traefik or should front and backend containers send these?
I think it would be good to send common ones through traefik and then send service specific ones by the application containers (CORS by backend for example)
The text was updated successfully, but these errors were encountered: