Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/bad_lines_from_member #2245

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/bad_lines_from_member #2245

wants to merge 3 commits into from

Conversation

worksofliam
Copy link
Contributor

Changes

Solves issue where source member lines that were just numerics, but had leading zeros, were not being returned correctly because the CSV was casting and interpreting those lines are numbers, and therefore removing the leading zeros/characters from the line.

How to test this PR

Examples:

  1. Run the test cases
  2. Run the test case created for this issue

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam worksofliam linked an issue Sep 3, 2024 that may be closed by this pull request
Supress Zeros when ctdata Arrays #2244
Open
@worksofliam worksofliam added the ready Ready for review label Sep 3, 2024
@chrjorgensen
Copy link
Collaborator

@worksofliam @julesyan How did you recreate this error? I'm not able to recreate it with the master branch without this change...

And there is no test case described...

Having to create test cases makes it easier to verify the code change - I thought it was tedious in the beginning but have come to appreciate it while testing other peoples code... and my own code! 😄

chrjorgensen
chrjorgensen requested changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@chrjorgensen chrjorgensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@worksofliam See my comment above... 😉

@julesyan
Copy link
Collaborator

julesyan commented Sep 9, 2024

@chrjorgensen i ran the steps in the test case "Ensure source lines are correct" on the master branch and on this branch. I assumed the test case itself was correct.

@worksofliam
Copy link
Contributor Author

@chrjorgensen Here is the test case in this PR: https://github.com/codefori/vscode-ibmi/pull/2245/files#diff-bdc40b7bbc93e3369a9b963b709ed6bc8d4d9d70db7362e1f14d6edc78c07cd6R281

When recreating, make sure you have source dates enabled.

@chrjorgensen
Copy link
Collaborator

@julesyan @worksofliam Okay, I didn't look at the code, just saw the section "How to test this PR" above...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julesyan julesyan julesyan approved these changes

@sebjulliand sebjulliand Awaiting requested review from sebjulliand

@chrjorgensen chrjorgensen Awaiting requested review from chrjorgensen

Assignees
No one assigned
Labels
ready Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supress Zeros when ctdata Arrays
3 participants
@worksofliam @chrjorgensen @julesyan