Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP to support update production #2196

Open
worksofliam opened this issue Jul 24, 2024 · 3 comments
Open

SEP to support update production #2196

worksofliam opened this issue Jul 24, 2024 · 3 comments
Labels
bug A confirmed issue when something isn't working as intended debug Debug client issue (IBM)

Comments

@worksofliam
Copy link
Contributor

This command we call to the debugger doesn't look like we pass in update debug like we do for batch.

We need an additional Boolean parameter to ibmidebug.create-service-entry-point-with-prompt to control this.

https://github.com/codefori/vscode-ibmi/blob/master/src/api/debug/index.ts#L457

@worksofliam worksofliam added bug A confirmed issue when something isn't working as intended debug Debug client issue (IBM) labels Jul 24, 2024
@mkwan01
Copy link

mkwan01 commented Jul 25, 2024

This is an enhancement we can add in the next release. As a complete user story, only adding a parameter to ibmidebug.create-service-entry-point-with-prompt is not enough. We also need to add an action on an SEP object to toggle this setting and also show the setting value in the SEP view.

@mkwan01
Copy link

mkwan01 commented Aug 22, 2024

I will use a simpler implementation, which just honours the "update production files" setting from the code-for-i debug settings page when setting an SEP. We will only go with the more expensive solution of making this setting configurable for each SEP, if there is such a requirement later.

@mkwan01
Copy link

mkwan01 commented Aug 22, 2024

Just figured out that we also need to update the debug service for this one. SEP debug uses the attach launch configuration. We are not passing the updateProductionFiles setting in the attach launch right now. I will discuss with the team on when we can rebuild the debug service PTF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended debug Debug client issue (IBM)
Projects
None yet
Development

No branches or pull requests

2 participants