-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Truck Logo Image sizes #41
Comments
Sounds good to address the aspect ratio for a consistent consumer ux. I expect challenges in getting the truck vendors to adhere to a standard, and just resizing or auto-cropping often yeilds sub-par results. Is there an easy Drupal drop in for cropping images in the browser? Alternatively since there won't be that many trucks, and I don't expect them to update their logo too often, we could just allow them to upload whatever and ping one of us to 'clean it up' afterwards. |
right, exactly. So I am asking to know what that size and aspect ratio should be. |
@aaronsalmon It appears the logo aspect ratios in your Balsamic differ between the Vendor and Consumer sides. The consumer side is our target for which the balsamic has a wide image, so perhaps we should lock in on a simple and common aspect ratio like 3:2? @Lowell20 As far as sizing what we keep on the drupal servers I lean towards keeping a bit larger than we need, perhaps 400 pixels wide with reasonable compression; just let the browser downsize the dimensions matching the same ratio. Keeps things simple so we don't prematurely optimize. |
If you mean data size upload restriction I think it's preferable to just let the user here upload whatever and compress ourselves (be it manually or automatically, including re-sizing dimensions or not). If you mean some other Drupal magic then great we'll have to see what it is. |
Let's decide on what size and aspect ratio we want for the logo images.
I can provide resized image paths in the json automatically which might provide a more consistent experience for the consumer javascript.
We should also decide in some kind of image upload parameters for the food truck users in the admin ui.
The text was updated successfully, but these errors were encountered: