Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drupal] MVP API #18

Closed
4 tasks done
AnthonyAstige opened this issue May 17, 2016 · 10 comments
Closed
4 tasks done

[Drupal] MVP API #18

AnthonyAstige opened this issue May 17, 2016 · 10 comments
Milestone

Comments

@AnthonyAstige
Copy link
Member

AnthonyAstige commented May 17, 2016

The [Consumer] side needs this data / api to work

@AnthonyAstige AnthonyAstige added this to the MVP milestone May 17, 2016
@Lowell20
Copy link
Contributor

@AnthonyAstige do you know if we will want to filter by a date range or maybe, to keep it simple, just individual dates. For example, the consumer side could send multiple requests, one for each date it needs data for. This is just a thought, just let me know what you think you will be looking for

@AnthonyAstige
Copy link
Member Author

@Lowell20 Just one date at a time sounds good for the MVP.

@aaronsalmon - See Lowell's prior comment, in case you're wire framing up something we may have a need for a date range search soon.

@AnthonyAstige
Copy link
Member Author

@Lowell20 - The api gives dates like "2016-05-04T01:30:00". It looks like UTC, but we think UTC usually has a Z at the end. We need to be sure we're doing the right stuff with times/timezones. Can you confirm it's a standard time format and let us know how to identify the timezone, and/or patch it?

@Lowell20
Copy link
Contributor

@Lowell20
Copy link
Contributor

I can confirm it is UTC time

@Lowell20 Lowell20 assigned AnthonyAstige and unassigned Lowell20 May 24, 2016
@AnthonyAstige
Copy link
Member Author

@Lowell20
Copy link
Contributor

I think my goal is to filter the results by a date or date range, the "date-or-timestamp" text can be replaced with the query parameters.
Right now it is just a placeholder until we know what kinds of parameters we will be sending through

@levifelling
Copy link
Contributor

For the MVP we would need API endpoints for:

  1. all events (useful for dev, but not required for MVP)
    http://vendors.foodtrucks.codeforeauclaire.org/api/events
  2. events where start_time or end_time is on the given day
    http://vendors.foodtrucks.codeforeauclaire.org/api/events/{date UTC}
    http://vendors.foodtrucks.codeforeauclaire.org/api/events/2016-05-26T00:00:00
  3. a single event by uuid
    http://vendors.foodtrucks.codeforeauclaire.org/api/events/{uuid}
    http://vendors.foodtrucks.codeforeauclaire.org/api/events/5ec386b2-a9f8-4a79-9b46-f9e9aff1fd08

I'm no too particular on how you want to format the API so long as we can get access to the data.

@AnthonyAstige
Copy link
Member Author

RE: 2. Simpler and more clear I think to just have the date with no time in the url imo. ie;
http://vendors.foodtrucks.codeforeauclaire.org/api/events/2016-05-26

RE: 3. I'm not sure we need single event query in the API for the MVP - #30 can easily retrieve by date and filter locally by Event UUID. (#38 for lodash opened to help here)

@Lowell20 Lowell20 removed their assignment May 31, 2016
@AnthonyAstige
Copy link
Member Author

We have enough in the API now I think for MVP. Issues will fall out while coding as needed from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants