-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for xcresult-based uploads in v4
.
#1367
Comments
@Supereg Thank you for raising this issue; an issue we are struggling with across our GitHub organization and multiple projects. |
# Revert to CodeCov 3 For Now ## ⚙️ Release Notes - See codecov/codecov-action#1367 for more details. Unfortunately we have not received any response from the codecov team so far; we will investigate other tools and solutions in the meantime or see if we can somehow contribute to codecov to support them. ### Code of Conduct & Contributing Guidelines By submitting creating this pull request, you agree to follow our [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md): - [x] I agree to follow the [Code of Conduct](https://github.com/StanfordBDHG/.github/blob/main/CODE_OF_CONDUCT.md) and [Contributing Guidelines](https://github.com/StanfordBDHG/.github/blob/main/CONTRIBUTING.md). --------- Signed-off-by: Paul Schmiedmayer <[email protected]>
@Supereg Can you share the .yml file? I want to see how you implemented that in v3. I am facing issues. I will be thankful to you. |
@Zee326 create-and-upload-coverage-report.yml is our action that uploads the coverage reports collected from the xcodebuild-or-fastlane.yml action. |
We went with the approach seen at bitwarden/authenticator-ios@2edaf9b to work around this issue. Looking forward to this being automated so we can avoid installing and using |
This can be addressed by codecov/uploader#1078 |
Problem
We found that tokenless uploads using action
v3
are essential broken since Friday (e.g., see https://github.com/StanfordBDHG/LLMonFHIR/actions/runs/8592479578/job/23631941264).This encouraged to explore an upgrade to the
v4
action using organization wide tokens (nice feature btw). However, we quickly found that thexcode
andxcode_archive_path
options were completely removed fromv4
without clear instructions on how to migrate.So our question is, what are the drop in replacements for the
xcode
andxcode_archive_path
options withv4
? Arexcresult
-based coverage uploads still supported (if so, how?) or were they just silently removed?We would highly appreciate respective migration guides or according documentation for the most prominent use cases as both are currently completely missing.
I tired my best to provide you the best possible overview of our current situation and hope you can provide helpful feedback and point us towards the next steps.
Current Workflow
To highlight our current workflow:
.xcresult
file with collected code coverage.xcrun xcresulttool merge ...
creating a newCodeCoverage.xcresult
.xcode: true
andxcode_archive_path: CodeCoverage.xcresult
options to upload the coverage report. This step is seemingly not possible anymore.What we've tried
I tried to explore how such interactions are handled with
v4
. CLI options seem to mention some form ofxcode
plugin to be available (see https://docs.codecov.com/docs/cli-options#do-upload). The Supported Coverage Report Formats also still seem to mention some txt-based Xcode code coverage format. Also, when running codecovcli locally it randomly pulls code coverage reports from all, completely unrelated Xcode projects in derived data into the current directory (Not sure if that is the intended new way?). This doesn't work with our current workflow, as we don't have the derived data available (also we don't use the global derrivedData directory), as we have a dedicated step to assemble a self-containedxcresult
package.Attempts that failed
I have tried to manually convert the code coverage report of a
xcresult
package into a format that codecov understands. Simple attempts by just manually pulling out the coverage format in json or txt have failed (e.g., using thexcrun xccov view --report --json CodeCoverage.xcresult > cov.json
). While the overall upload action completed successfully (by supplying thefile
argument with the respective output), the UI shows the errornull
. Not super helpful. See https://app.codecov.io/github/StanfordSpezi/SpeziFileFormats/commit/0a7434be32dea2e44e126f314ab9b116ec042e39.CC: @PSchmiedmayer @philippzagar @vishnuravi
Tasks
The text was updated successfully, but these errors were encountered: