Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make niceml init usable without poetry #24

Open
ankeko opened this issue May 17, 2023 · 1 comment
Open

make niceml init usable without poetry #24

ankeko opened this issue May 17, 2023 · 1 comment
Assignees
Labels
✨ feature Requests or discussions about new features

Comments

@ankeko
Copy link
Collaborator

ankeko commented May 17, 2023

Currently a poetry environment, or more explicitly a pyproject.toml, is required to successfully perform the initialization of a niceML project.
By changing the niceML init process this prerequisite can be avoided. All information collected from the pyproject.toml should be requested during the niceml init process, if the file is not present.

@ankeko ankeko added the ✨ feature Requests or discussions about new features label May 17, 2023
@benjaminbauer
Copy link
Collaborator

benjaminbauer commented Jun 14, 2023

Also most of the properties that are currently being read from the pyproject.toml are canonically not in the [tool.poetry] section, but should rather be tool independent in the [project] section as specified in PEP621.

I propose to look for the desired properties in these locations, in this order:

  1. pyproject.toml [project]
  2. pyproject.toml [tool.poetry]
  3. ask for user input

I would prefer it when niceml does not have hard ties to poetry to enable:

  1. Alternatives when working with virtualenvs (e.g. PDM)
  2. Alternatives to working with virtualenvs
    1. conda
    2. going bare-metal with pip when using devcontaines.
  3. people who want to try this out outside of a project with a "standalone" installation via pipx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Requests or discussions about new features
Projects
None yet
Development

No branches or pull requests

3 participants