Merge pull request #5 from codebar-ag/feature-tickets

Feature Tickets

Author: StanBarrows

.github/ISSUE_TEMPLATE/config.yml

@@ -1,10 +1,10 @@
 blank_issues_enabled: false
 contact_links:
   - name: Ask a question
-    url: https://github.com/codebar-ag/laravel-zendesk/discussions/new?category=q-a
+    url: https://github.com/codebar-ag/laravel-zendesk/issues/new
     about: Ask the community for help
   - name: Request a feature
-    url: https://github.com/codebar-ag/laravel-zendesk/discussions/new?category=ideas
+    url: https://github.com/codebar-ag/laravel-zendesk/issues/new
     about: Share ideas for new features
   - name: Report a bug
     url: https://github.com/codebar-ag/laravel-zendesk/issues/new

README.md

@@ -39,7 +39,7 @@ composer require codebar-ag/laravel-zendesk
 Optionally, you can publish the config file with:
 
 ```bash
-php artisan vendor:publish --provider="CodebarAg\Zendesk\ZendeskServiceProvider" --tag="config"
+php artisan vendor:publish --provider="CodebarAg\Zendesk\ZendeskServiceProvider"
 ```
 
 You can add the following env variables to your `.env` file:
@@ -207,6 +207,8 @@ $uploadResponse = $connector->send(
 
 $token = $uploadResponse->dto()->token;
 
+// And to pass to your ticket request
+
 $ticketResponse = $connector->send(
     new CreateSingleTicketRequest(
         SingleTicketDTO::fromArray([

composer.json

@@ -60,7 +60,8 @@
         "allow-plugins": {
             "composer/package-versions-deprecated": false,
             "pestphp/pest-plugin": true,
-            "phpstan/extension-installer": true
+            "phpstan/extension-installer": true,
+            "dealerdirect/phpcodesniffer-composer-installer": true
         }
     },
     "extra": {

src/Dto/Tickets/AllTicketsDTO.php

@@ -2,7 +2,6 @@
 
 namespace CodebarAg\Zendesk\Dto\Tickets;
 
-use Illuminate\Support\Collection;
 use Saloon\Http\Response;
 use Spatie\LaravelData\Data;
 
@@ -20,7 +19,7 @@ public static function fromResponse(Response $response): self
     {
         $data = $response->json();
 
-        return new static(
+        return new self(
             tickets: collect($data['tickets'])->map(function (array $ticket) {
                 return SingleTicketDTO::fromArray($ticket);
             })->toArray(),

src/Dto/Tickets/Attachments/AttachmentDTO.php

@@ -3,8 +3,6 @@
 namespace CodebarAg\Zendesk\Dto\Tickets\Attachments;
 
 use CodebarAg\Zendesk\Enums\MalwareScanResult;
-use Illuminate\Support\Carbon;
-use Saloon\Http\Response;
 use Spatie\LaravelData\Data;
 
 class AttachmentDTO extends Data
@@ -37,7 +35,7 @@ public static function fromArray(array $data): self
             }
         }
 
-        return new static(
+        return new self(
             content_type: $data['content_type'] ?? null,
             content_url: $data['content_url'] ?? null,
             deleted: $data['deleted'] ?? null,

src/Dto/Tickets/Attachments/ThumbnailDTO.php

@@ -26,7 +26,7 @@ public function __construct(
 
     public static function fromArray(array $data): self
     {
-        return new static(
+        return new self(
             content_type: $data['content_type'] ?? null,
             content_url: $data['content_url'] ?? null,
             deleted: $data['deleted'] ?? null,

src/Dto/Tickets/Attachments/UploadDTO.php

@@ -2,7 +2,6 @@
 
 namespace CodebarAg\Zendesk\Dto\Tickets\Attachments;
 
-use CodebarAg\Zendesk\Enums\MalwareScanResult;
 use Illuminate\Support\Carbon;
 use Saloon\Http\Response;
 use Spatie\LaravelData\Data;
@@ -34,7 +33,7 @@ public static function fromArray(array $data): self
             }
         }
 
-        return new static(
+        return new self(
             token: $data['token'] ?? null,
             expires_at: Carbon::parse($data['expires_at'] ?? null),
             attachments: $attachments,

src/Dto/Tickets/Comments/CommentDTO.php

@@ -2,8 +2,6 @@
 
 namespace CodebarAg\Zendesk\Dto\Tickets\Comments;
 
-use CodebarAg\Zendesk\Dto\Tickets\Attachments\AttachmentDTO;
-use CodebarAg\Zendesk\Dto\Tickets\SingleTicketDTO;
 use Illuminate\Support\Carbon;
 use Spatie\LaravelData\Data;
 
@@ -28,7 +26,7 @@ public function __construct(
 
     public static function fromArray(array $data): self
     {
-        return new static(
+        return new self(
             attachments: $data['attachments'] ?? null,
             audit_id: $data['audit_id'] ?? null,
             author_id: $data['author_id'] ?? null,

src/Dto/Tickets/CountTicketsDTO.php

@@ -18,7 +18,7 @@ public static function fromResponse(Response $response): self
     {
         $data = $response->json()['count'];
 
-        return new static(
+        return new self(
             value: $data['value'],
             refreshed_at: Carbon::parse($data['refreshed_at']),
         );

src/Dto/Tickets/SingleTicketDTO.php

@@ -8,7 +8,6 @@
 use Illuminate\Support\Carbon;
 use Saloon\Http\Response;
 use Spatie\LaravelData\Data;
-use function Pest\Laravel\instance;
 
 class SingleTicketDTO extends Data
 {
@@ -82,19 +81,19 @@ public static function fromArray(array $data): self
             $comment = CommentDTO::fromArray($comment);
         }
 
-        $priority =  array_key_exists('priority', $data) ? $data['priority'] : null;
+        $priority = array_key_exists('priority', $data) ? $data['priority'] : null;
 
         if ($priority && ! $priority instanceof TicketPriority) {
             $priority = TicketPriority::tryFrom($priority);
         }
 
-        $type =  array_key_exists('type', $data) ? $data['type'] : null;
+        $type = array_key_exists('type', $data) ? $data['type'] : null;
 
         if ($type && ! $type instanceof TicketType) {
             $type = TicketType::tryFrom($type);
         }
 
-        return new static(
+        return new self(
             allow_attachments: $data['allow_attachments'] ?? null,
             allow_channelback: $data['allow_channelback'] ?? null,
             assignee_email: $data['assignee_email'] ?? null,