Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add : sidgureja7803 - Added Voice Search and Skills Dropdown Functionality #386

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add : sidgureja7803 - Added Voice Search and Skills Dropdown Functionality #386

wants to merge 3 commits into from
+171 −15

Conversation

sidgureja7803
Copy link

@sidgureja7803 sidgureja7803 commented Oct 22, 2024 •
edited
Loading

Description

Currently, users can only search for people and select skills by manually typing in the search bar and skill selection field. This can be time-consuming and may not provide the best user experience.

Related Issues

1- There is no voice search functionality, requiring users to type out search queries manually.
2 - The skills field requires users to manually input their skills, which can be cumbersome.

Changes Proposed

1 - Voice Search: Add a feature that allows users to search for people using voice input instead of typing.
2 - Skills Dropdown: Add a dropdown menu to the skills selection field, allowing users to select from a list of predefined skills without needing to type.

Checklist

  • I have read and followed the Contribution Guidelines.
  • All new and existing tests passed.
  • I have updated the documentation to reflect the changes I've made.
  • My code follows the code style of this project.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2024-10-23 014430
Screenshot 2024-10-23 014443

Note to reviewers

Please review and approve this PR ASAP as it might cause conflicts after users are added, in the ProfileList.json file.

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
devdisplay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 6:39am

@netlify Netlify
Copy link

netlify bot commented Oct 22, 2024 •
edited
Loading

❌ Deploy Preview for devdisplay failed.

Name Link
🔨 Latest commit ad667a1
🔍 Latest deploy log https://app.netlify.com/sites/devdisplay/deploys/671899e05497830008219046

@sidgureja7803
Copy link
Author

@ishap11 , Please review this PR and kindly merge it.
And please tell, why the checks are failing ??

@ishap11
Copy link
Collaborator

ishap11 commented Oct 23, 2024 •
edited
Loading

Hi @sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

The checks are failing due to a syntax issue in the ProfileList.json file. This often happens when multiple people add their names to the file at the same time. If two contributors make changes without proper coordination, it can lead to issues like missing commas or incorrect JSON structure, which causes the checks to fail.

The failing checks are related to Netlify’s deployment process, which seems to be a configuration issue rather than something caused by your code. The Vercel deployment passed successfully, so it's likely a project setup or admin-related issue with Netlify.

I'll notify the admin to check the Netlify settings and resolve the deployment failure. You're good on your end!

Thanks!

@sidgureja7803
Copy link
Author

Hi @sidgureja7803 , could you please let me know the issue number where the voice search and skills dropdown task is assigned?

The checks are failing due to a syntax issue in the Profile-List.json file. This often happens when multiple people add their names to the file at the same time. If two contributors make changes without proper coordination, it can lead to issues like missing commas or incorrect JSON structure, which causes the checks to fail.

The failing checks are related to Netlify’s deployment process, which seems to be a configuration issue rather than something caused by your code. The Vercel deployment passed successfully, so it's likely a project setup or admin-related issue with Netlify.

I'll notify the admin to check the Netlify settings and resolve the deployment failure. You're good on your end!

Thanks!

These checks are failing because when I created this PR, after that many people registered their name in the ProfilesList.json file.
So it is creating conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sidgureja7803 @ishap11