-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: new video frame is not responsive #1577
Comments
The new player the videos are not clear even in best resolution.But in earlier videos which was uploaded before 13 are very clear it would be helpful if we do as earlier. |
Related to code100x#1577 Update video player to be fully responsive * Modify `src/app/globals.css` to ensure the video player is fully responsive for different screen sizes and handle the video frame's width and height correctly. * Change `src/components/VideoPlayer2.tsx` to remove the fixed maximum width of 850px and adjust the video player container to take full width and height. * Update `src/components/VideoPlayerSegment.tsx` to include styles and configurations to make the video frame responsive. * Add `src/components/VideoPlayer.tsx` to handle different screen sizes and ensure the video frame takes its full width and height.
@SujithThirumalaisamy can you fix the appx iframe video palyer on all the screens in case you are free? |
Hey Sargam, if he’s not available, you can assign this to me. I’ll start working on it tonight if you assign |
@devsargam I’ve resolved this same issue for all screen sizes and opened a PR #1625 . Could you review it whenever you get a chance? |
@devsargam sir, frame of appx and version should be responsive and fit according to screen and max-width set 850-px which is fit in screen on every type of screen. even after pr #1625 do some good work but we should set it to some max-width so it does not overflow which looks bad . |
Describe the bug
A new update came with week 13 , so new frame of video is not responsive , not taking his full width and , even height is overflow. And even full size , mini player are not available.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
as we can see in previous lecture like week-12 and other previous one's which is responsive and taking
max width-850px .
Screenshots or GIFs
Info (please complete the following information):
Additional context
no
The text was updated successfully, but these errors were encountered: