Skip to content

Commit 12e9d4c

Browse files
committed
upgrade to 3.0
1 parent d4777c3 commit 12e9d4c

26 files changed

+3615
-2484
lines changed

.editorconfig

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -13,22 +13,8 @@ insert_final_newline = true
1313
indent_style = space
1414
indent_size = 2
1515

16-
[*.js]
17-
indent_style = space
18-
indent_size = 2
19-
2016
[*.hbs]
2117
insert_final_newline = false
22-
indent_style = space
23-
indent_size = 2
24-
25-
[*.css]
26-
indent_style = space
27-
indent_size = 2
28-
29-
[*.html]
30-
indent_style = space
31-
indent_size = 2
3218

3319
[*.{diff,md}]
3420
trim_trailing_whitespace = false

.eslintrc.js

Lines changed: 38 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,48 @@
11
module.exports = {
22
root: true,
33
parserOptions: {
4-
ecmaVersion: 6,
4+
ecmaVersion: 2017,
55
sourceType: 'module'
66
},
7-
extends: 'eslint:recommended',
7+
plugins: [
8+
'ember'
9+
],
10+
extends: [
11+
'eslint:recommended',
12+
'plugin:ember/recommended'
13+
],
814
env: {
915
browser: true
1016
},
1117
rules: {
12-
}
18+
},
19+
overrides: [
20+
// node files
21+
{
22+
files: [
23+
'index.js',
24+
'testem.js',
25+
'ember-cli-build.js',
26+
'config/**/*.js',
27+
'tests/dummy/config/**/*.js'
28+
],
29+
excludedFiles: [
30+
'app/**',
31+
'addon/**',
32+
'tests/dummy/app/**'
33+
],
34+
parserOptions: {
35+
sourceType: 'script',
36+
ecmaVersion: 2015
37+
},
38+
env: {
39+
browser: false,
40+
node: true
41+
},
42+
plugins: ['node'],
43+
rules: Object.assign({}, require('eslint-plugin-node').configs.recommended.rules, {
44+
// add your custom rules and overrides for node files here
45+
})
46+
}
47+
]
1348
};

.gitignore

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# See http://help.github.com/ignore-files/ for more about ignoring files.
1+
# See https://help.github.com/ignore-files/ for more about ignoring files.
22

33
# compiled output
44
/dist
@@ -14,7 +14,10 @@
1414
/coverage/*
1515
/libpeerconnection.log
1616
npm-debug.log*
17+
yarn-error.log
1718
testem.log
18-
test-results.xml
19-
.envrc
20-
.DS_Store
19+
20+
# ember-try
21+
.node_modules.ember-try/
22+
bower.json.ember-try
23+
package.json.ember-try

.npmignore

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,15 @@
77
.bowerrc
88
.editorconfig
99
.ember-cli
10-
.gitignore
1110
.eslintrc.js
11+
.gitignore
1212
.watchmanconfig
1313
.travis.yml
1414
bower.json
1515
ember-cli-build.js
1616
testem.js
17+
18+
# ember-try
19+
.node_modules.ember-try/
20+
bower.json.ember-try
21+
package.json.ember-try

.travis.yml

Lines changed: 26 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,40 +1,48 @@
11
---
22
language: node_js
33
node_js:
4-
- "6"
4+
# we recommend testing addons with the same minimum supported node version as Ember CLI
5+
# so that your addon works for all apps
6+
- "4"
57

68
sudo: false
9+
dist: trusty
10+
11+
addons:
12+
chrome: stable
713

814
cache:
9-
directories:
10-
- $HOME/.npm
11-
- $HOME/.cache # includes bowers cache
15+
yarn: true
1216

1317
env:
14-
# we recommend testing LTS's and latest stable release (bonus points to beta/canary)
15-
- EMBER_TRY_SCENARIO=ember-lts-2.4
16-
- EMBER_TRY_SCENARIO=ember-lts-2.8
17-
- EMBER_TRY_SCENARIO=ember-release
18-
- EMBER_TRY_SCENARIO=ember-beta
19-
- EMBER_TRY_SCENARIO=ember-canary
20-
- EMBER_TRY_SCENARIO=ember-default
18+
global:
19+
# See https://git.io/vdao3 for details.
20+
- JOBS=1
21+
matrix:
22+
# we recommend new addons test the current and previous LTS
23+
# as well as latest stable release (bonus points to beta/canary)
24+
- EMBER_TRY_SCENARIO=ember-lts-2.12
25+
- EMBER_TRY_SCENARIO=ember-lts-2.16
26+
- EMBER_TRY_SCENARIO=ember-lts-2.18
27+
- EMBER_TRY_SCENARIO=ember-release
28+
- EMBER_TRY_SCENARIO=ember-beta
29+
- EMBER_TRY_SCENARIO=ember-canary
30+
- EMBER_TRY_SCENARIO=ember-default
2131

2232
matrix:
2333
fast_finish: true
2434
allow_failures:
2535
- env: EMBER_TRY_SCENARIO=ember-canary
2636

2737
before_install:
28-
- npm config set spin false
29-
- npm install -g bower phantomjs-prebuilt
30-
- bower --version
31-
- phantomjs --version
38+
- curl -o- -L https://yarnpkg.com/install.sh | bash
39+
- export PATH=$HOME/.yarn/bin:$PATH
3240

3341
install:
34-
- npm install
35-
- bower install
42+
- yarn install --no-lockfile --non-interactive
3643

3744
script:
45+
- yarn lint:js
3846
# Usually, it's ok to finish the test scenario without reverting
3947
# to the addon's original dependency state, skipping "cleanup".
40-
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO test --skip-cleanup
48+
- node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO --skip-cleanup

addon/services/stripe.js

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,21 @@
11
/* global Stripe */
2+
import { isEqual, typeOf } from '@ember/utils';
3+
4+
import { resolve, Promise as EmberPromise } from 'rsvp';
5+
import { registerWaiter } from '@ember/test';
6+
import { readOnly } from '@ember/object/computed';
7+
import Service from '@ember/service';
28
import Ember from 'ember';
39
import loadScript from 'ember-stripe-service/utils/load-script';
410

5-
export default Ember.Service.extend({
11+
export default Service.extend({
612
didConfigure: false,
713
config: null,
814

9-
lazyLoad: Ember.computed.readOnly('config.lazyLoad'),
10-
mock: Ember.computed.readOnly('config.mock'),
11-
publishableKey: Ember.computed.readOnly('config.publishableKey'),
12-
debuggingEnabled: Ember.computed.readOnly('config.debug'),
15+
lazyLoad: readOnly('config.lazyLoad'),
16+
mock: readOnly('config.mock'),
17+
publishableKey: readOnly('config.publishableKey'),
18+
debuggingEnabled: readOnly('config.debug'),
1319

1420
runCount: 0,
1521

@@ -23,7 +29,7 @@ export default Ember.Service.extend({
2329
this._waiter = () => {
2430
return this.get('runCount') === 0;
2531
};
26-
Ember.Test.registerWaiter(this._waiter);
32+
registerWaiter(this._waiter);
2733
}
2834

2935
if (!lazyLoad || mock) {
@@ -37,7 +43,7 @@ export default Ember.Service.extend({
3743

3844
let loadJs = lazyLoad && !mock ?
3945
loadScript("https://js.stripe.com/v2/") :
40-
Ember.RSVP.resolve();
46+
resolve();
4147

4248
return loadJs.then(() => {
4349
this.configure();
@@ -74,7 +80,7 @@ export default Ember.Service.extend({
7480

7581
stripePromise(callback) {
7682
return this.load().then(() => {
77-
return new Ember.RSVP.Promise((resolve, reject) => {
83+
return new EmberPromise((resolve, reject) => {
7884
callback(resolve, reject);
7985
});
8086
});
@@ -177,7 +183,7 @@ export default Ember.Service.extend({
177183
},
178184

179185
_checkForAndAddCardFn(name, fn) {
180-
if (Ember.isEqual(Ember.typeOf(Stripe.card[name]), 'function')) {
186+
if (isEqual(typeOf(Stripe.card[name]), 'function')) {
181187
this.card[name] = fn;
182188
} else {
183189
this.card[name] = function() {};

addon/utils/load-script.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import Ember from 'ember';
1+
import { run } from '@ember/runloop';
2+
import { Promise as EmberPromise } from 'rsvp';
23

34
/*
45
* loadScript will load a JavaScript asset. Subsequent load
@@ -11,18 +12,18 @@ let loadedScripts = {};
1112
export default function loadScript(url) {
1213
let promise = loadedScripts[url];
1314
if (!promise) {
14-
promise = new Ember.RSVP.Promise((resolve, reject) => {
15+
promise = new EmberPromise((resolve, reject) => {
1516
let element = document.createElement('script');
1617
element.type = 'text/javascript';
1718
element.async = false;
1819
element.addEventListener('load', () => {
19-
Ember.run(() => {
20+
run(() => {
2021
resolve();
2122
});
2223
}, false);
2324
element.addEventListener('error', () => {
2425
let error = new Error(`Could not load script ${url}`);
25-
Ember.run(() => {
26+
run(() => {
2627
reject(error);
2728
});
2829
}, false);

app/initializers/ember-stripe-service.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import EmberError from '@ember/error';
12
import Ember from 'ember';
23
import StripeMock from 'ember-stripe-service/utils/stripe-mock';
34
import config from '../config/environment';
@@ -16,7 +17,7 @@ export function initialize() {
1617
}
1718

1819
if (!stripeConfig.publishableKey) {
19-
throw new Ember.Error("StripeService: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
20+
throw new EmberError("StripeService: Missing Stripe key, please set `ENV.stripe.publishableKey` in config.environment.js");
2021
}
2122

2223
if (typeof FastBoot !== 'undefined' || stripeConfig.mock) {

0 commit comments

Comments
 (0)