M-12 MitigationConfirmed

[c4-bot-3]

Lines of code

Vulnerability details

Original Issue Summary

• M-12: Incorrect exchange rate provided to Balancer pools

In the original issue, getRate() does not check for outdated exchange rates, which can result to incorrect calculations.

Mitigation

• Mitigation M-12

The mitigation proposes a staleness-check:

-        (uint256 _lastPrice, ) = getMintRate();
+        (uint256 _lastPrice, uint256 _lastPriceTimestamp) = getMintRate();
+        if (block.timestamp > _lastPriceTimestamp + 1 days) {
+            revert OraclePriceExpired();
+        }

Comments

This mitigation succesfully mitigates the original issue. The usage of _lastPriceTimestamp and checking if block.timestamp is more than _lastPriceTimestamp + 1 days will ensure that the price can not be stale.

Suggestion

n/a

Conclusion

LGTM

[c4-judge]

alcueca marked the issue as satisfactory