M-02 MitigationConfirmed

[c4-bot-5]

Lines of code

Vulnerability details

Original Issue Summary

• M-02: Withdrawals and Claims are meant to be pausable, but it is not possible in practice

In the original issue, WithdrawQueue.sol inherits from PausableUpgradeable. However, the whenNotPaused modifier is not used, resulting in withdrawals and claims not being able to be paused.

Mitigation

• Mitigation M-02

This mitigation proposes the usage of the whenNotPaused modifier:

-    function withdraw(uint256 _amount, address _assetOut) external nonReentrant {
+    function withdraw(uint256 _amount, address _assetOut) external nonReentrant whenNotPaused {

-    function claim(uint256 withdrawRequestIndex) external nonReentrant {
+    function claim(uint256 withdrawRequestIndex) external nonReentrant whenNotPaused {

Comments

This mitigation succesfully mitigates the original issue. Due to the proposed usage of whenNotPaused, when the project decides to call pause(), users will not be able to call withdraw() or claim(), resulting in succesfully pausing these functions.

Suggestion

n/a

Conclusion

LGTM

[c4-judge]

alcueca marked the issue as satisfactory