Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H-3 MitigationConfirmed #42

Open
c4-bot-8 opened this issue Jun 7, 2024 · 2 comments
Open

H-3 MitigationConfirmed #42

c4-bot-8 opened this issue Jun 7, 2024 · 2 comments
Labels
mitigation-confirmed MR-H-03 satisfactory satisfies C4 submission criteria; eligible for awards

Comments

@c4-bot-8
Copy link
Contributor

c4-bot-8 commented Jun 7, 2024

Lines of code

Vulnerability details

Original Issue Summary

ETH withdrawals from EigenLayer require a reentrancy in receive(). However, the receive() function uses the nonReentrant modifier, which prevents the reentrancy and ultimately resulting in ETH withdrawals from EigenLayer failing.

Mitigation

This mitigation proposes the removal of the nonReentrant modifier:

-    receive() external payable nonReentrant {
+    receive() external payable {

Comments

This mitigation succesfully mitigates H-03, reentrancy is now possible again in the receive() function, which means that the EigenLayer ETH withdraws will succeed.

Suggestion

n/a

Conclusion

LGTM

@liveactionllama
Copy link

Minor label update for consistency across all MR-H-03 submissions.

@c4-judge c4-judge added the satisfactory satisfies C4 submission criteria; eligible for awards label Jun 8, 2024
@c4-judge
Copy link

c4-judge commented Jun 8, 2024

alcueca marked the issue as satisfactory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mitigation-confirmed MR-H-03 satisfactory satisfies C4 submission criteria; eligible for awards
Projects
None yet
Development

No branches or pull requests

3 participants